From: Johan Hovold <jhovold@gmail.com>
To: Greg KH <gregkh@suse.de>
Cc: Alon Ziv <alon+git@nolaviz.org>,
linux-usb@vger.kernel.org, Stefani Seibold <stefani@seibold.net>,
Jason Wessel <jason.wessel@windriver.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] Export usb_serial_generic_write_room for use in other modules
Date: Sat, 23 Oct 2010 22:29:53 +0200 [thread overview]
Message-ID: <20101023202953.GA10343@localhost> (raw)
In-Reply-To: <20101023163747.GA20381@suse.de>
On Sat, Oct 23, 2010 at 09:37:47AM -0700, Greg KH wrote:
> On Sat, Oct 23, 2010 at 06:20:17PM +0200, Alon Ziv wrote:
> > Any module using usb_serial_generic_write (which is already exported)
> > had better use usb_serial_generic_write_room as well.
>
> Are you implying that the one driver using this function today is
> broken? Care to provide a patch for it as well?
Actually, most usb serial drivers use usb_serial_generic_write as well
as usb_serial_generic_write_room. The generic implementations are used
unless drivers explicitly define their own. So far there has been no
need to export usb_serial_generic_write_room but perhaps Alon's patch
does require this.
Either way the patch description is thus actually wrong (or rather
misleading) as it stands.
I'll try to have a look at the other patch tomorrow.
Johan
next prev parent reply other threads:[~2010-10-23 20:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1287850818-12050-1-git-send-email-alon-git@nolaviz.org>
2010-10-23 16:20 ` [PATCH 1/2] Export usb_serial_generic_write_room for use in other modules Alon Ziv
2010-10-23 16:37 ` Greg KH
2010-10-23 17:04 ` Alon Ziv
2010-10-24 8:37 ` Alan Cox
2010-10-24 18:10 ` Alon Ziv
2010-10-23 20:29 ` Johan Hovold [this message]
2010-10-23 16:20 ` [PATCH 2/2] OPN2001: use generic code where possible Alon Ziv
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101023202953.GA10343@localhost \
--to=jhovold@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=alon+git@nolaviz.org \
--cc=gregkh@suse.de \
--cc=jason.wessel@windriver.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=stefani@seibold.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.