From: Alon Ziv <alon@nolaviz.org>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Greg KH <gregkh@suse.de>, Alon Ziv <alon+git@nolaviz.org>,
linux-usb@vger.kernel.org, Johan Hovold <jhovold@gmail.com>,
Stefani Seibold <stefani@seibold.net>,
Jason Wessel <jason.wessel@windriver.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] Export usb_serial_generic_write_room for use in other modules
Date: Sun, 24 Oct 2010 20:10:57 +0200 [thread overview]
Message-ID: <4CC476B1.6090409@nolaviz.org> (raw)
In-Reply-To: <20101024093701.67850d1b@lxorguk.ukuu.org.uk>
On 10/24/2010 10:37 AM, Alan Cox wrote:
>> The generic code does not invoke the write_room callback before invoking
>> break_ctl, so there is no way to use this function in usb_serial.
>>
> Why would it ?
>
>
Oops, typo... Last sentence was supposed to end with "in usb_debug".
usb_debug invokes usb_serial_generic_write from break_ctl and ignores
the result; therefore, if there is no room in the generic write FIFO,
the write will fail. However--usb_debug _only_ uses
usb_serial_generic_write for break_ctl; so if there is no room, it is
because of a previous (uncompleted) break_ctl, and according to standard
UART semantics there is no difference between one break and two...
-a
next prev parent reply other threads:[~2010-10-24 18:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1287850818-12050-1-git-send-email-alon-git@nolaviz.org>
2010-10-23 16:20 ` [PATCH 1/2] Export usb_serial_generic_write_room for use in other modules Alon Ziv
2010-10-23 16:37 ` Greg KH
2010-10-23 17:04 ` Alon Ziv
2010-10-24 8:37 ` Alan Cox
2010-10-24 18:10 ` Alon Ziv [this message]
2010-10-23 20:29 ` Johan Hovold
2010-10-23 16:20 ` [PATCH 2/2] OPN2001: use generic code where possible Alon Ziv
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CC476B1.6090409@nolaviz.org \
--to=alon@nolaviz.org \
--cc=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=alon+git@nolaviz.org \
--cc=gregkh@suse.de \
--cc=jason.wessel@windriver.com \
--cc=jhovold@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=stefani@seibold.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.