From: David Miller <davem@davemloft.net>
To: mkl@pengutronix.de
Cc: masa-korg@dsn.okisemi.com, andrew.chih.howe.khor@intel.com,
sameo@linux.intel.com, margie.foster@intel.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
socketcan-core@lists.berlios.de, kok.howg.ewe@intel.com,
wg@grandegger.com, morinaga526@dsn.okisemi.com,
joel.clark@intel.com, yong.y.wang@intel.com, chripell@fsfe.org,
qi.wang@intel.com
Subject: Re: [PATCH net-next-2.6 v1] can: Topcliff: Update PCH_CAN driver to 2.6.35
Date: Sun, 24 Oct 2010 15:09:05 -0700 (PDT) [thread overview]
Message-ID: <20101024.150905.39179588.davem@davemloft.net> (raw)
In-Reply-To: <4CC4ADA5.8@pengutronix.de>
From: Marc Kleine-Budde <mkl@pengutronix.de>
Date: Mon, 25 Oct 2010 00:05:25 +0200
> On 10/24/2010 11:43 PM, David Miller wrote:
>> From: Masayuki Ohtak <masa-korg@dsn.okisemi.com>
>> Date: Fri, 15 Oct 2010 22:00:28 +0900
>>
>>> CAN driver of Topcliff PCH
>>>
>>> Topcliff PCH is the platform controller hub that is going to be used in
>>> Intel's upcoming general embedded platform. All IO peripherals in
>>> Topcliff PCH are actually devices sitting on AMBA bus.
>>> Topcliff PCH has CAN I/F. This driver enables CAN function.
>>>
>>> Signed-off-by: Masayuki Ohtake <masa-korg@dsn.okisemi.com>
>>
>> Applied, thanks.
>
> IMHO this driver needs some improvements. There are some open points
> from Wolfgangs and my review. On the other side, it's a new driver and
> there's some time left before it hits mainline.
When people have more than a week to review and provide feedback,
and don't, I have zero sympathy especially this early in the
release cycle.
So if adding it to the tree is what I have to do to get you guys to
post your comments and suggest fixes, then that's what I am going to
(continue) to do. :-)
WARNING: multiple messages have this Message-ID (diff)
From: David Miller <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
To: mkl-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org
Cc: andrew.chih.howe.khor-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
socketcan-core-0fE9KPoRgkgATYTw5x5z8w@public.gmane.org,
sameo-VuQAYsv1563Yd54FQh9/CA@public.gmane.org,
margie.foster-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
chripell-VaTbYqLCNhc@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
yong.y.wang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
masa-korg-ECg8zkTtlr0C6LszWs/t0g@public.gmane.org,
kok.howg.ewe-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
joel.clark-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
morinaga526-ECg8zkTtlr0C6LszWs/t0g@public.gmane.org,
wg-5Yr1BZd7O62+XT7JhA+gdA@public.gmane.org,
qi.wang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org
Subject: Re: [PATCH net-next-2.6 v1] can: Topcliff: Update PCH_CAN driver to 2.6.35
Date: Sun, 24 Oct 2010 15:09:05 -0700 (PDT) [thread overview]
Message-ID: <20101024.150905.39179588.davem@davemloft.net> (raw)
In-Reply-To: <4CC4ADA5.8-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
From: Marc Kleine-Budde <mkl-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
Date: Mon, 25 Oct 2010 00:05:25 +0200
> On 10/24/2010 11:43 PM, David Miller wrote:
>> From: Masayuki Ohtak <masa-korg-ECg8zkTtlr0C6LszWs/t0g@public.gmane.org>
>> Date: Fri, 15 Oct 2010 22:00:28 +0900
>>
>>> CAN driver of Topcliff PCH
>>>
>>> Topcliff PCH is the platform controller hub that is going to be used in
>>> Intel's upcoming general embedded platform. All IO peripherals in
>>> Topcliff PCH are actually devices sitting on AMBA bus.
>>> Topcliff PCH has CAN I/F. This driver enables CAN function.
>>>
>>> Signed-off-by: Masayuki Ohtake <masa-korg-ECg8zkTtlr0C6LszWs/t0g@public.gmane.org>
>>
>> Applied, thanks.
>
> IMHO this driver needs some improvements. There are some open points
> from Wolfgangs and my review. On the other side, it's a new driver and
> there's some time left before it hits mainline.
When people have more than a week to review and provide feedback,
and don't, I have zero sympathy especially this early in the
release cycle.
So if adding it to the tree is what I have to do to get you guys to
post your comments and suggest fixes, then that's what I am going to
(continue) to do. :-)
next prev parent reply other threads:[~2010-10-24 22:08 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-15 13:00 [PATCH net-next-2.6 v1] can: Topcliff: Update PCH_CAN driver to 2.6.35 Masayuki Ohtak
2010-10-24 21:43 ` David Miller
2010-10-24 21:43 ` David Miller
2010-10-24 21:55 ` David Miller
2010-10-24 21:55 ` David Miller
2010-10-24 22:05 ` Marc Kleine-Budde
2010-10-24 22:05 ` Marc Kleine-Budde
2010-10-24 22:09 ` David Miller [this message]
2010-10-24 22:09 ` David Miller
2010-10-24 22:15 ` Marc Kleine-Budde
2010-10-24 22:15 ` Marc Kleine-Budde
2010-10-25 7:06 ` Wolfgang Grandegger
2010-10-25 7:06 ` Wolfgang Grandegger
[not found] ` <4CB8506C.3060600-ECg8zkTtlr0C6LszWs/t0g@public.gmane.org>
2010-10-25 6:37 ` Marc Kleine-Budde
-- strict thread matches above, loose matches on Subject: below --
2010-10-15 13:00 Masayuki Ohtak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101024.150905.39179588.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andrew.chih.howe.khor@intel.com \
--cc=chripell@fsfe.org \
--cc=joel.clark@intel.com \
--cc=kok.howg.ewe@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=margie.foster@intel.com \
--cc=masa-korg@dsn.okisemi.com \
--cc=mkl@pengutronix.de \
--cc=morinaga526@dsn.okisemi.com \
--cc=netdev@vger.kernel.org \
--cc=qi.wang@intel.com \
--cc=sameo@linux.intel.com \
--cc=socketcan-core@lists.berlios.de \
--cc=wg@grandegger.com \
--cc=yong.y.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.