All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] MIPS: MT: Fix build error iFPU affinity code
@ 2010-10-24 21:23 Ralf Baechle
  2010-10-25  0:40 ` KOSAKI Motohiro
  2010-10-25 10:15 ` James Morris
  0 siblings, 2 replies; 3+ messages in thread
From: Ralf Baechle @ 2010-10-24 21:23 UTC (permalink / raw)
  To: Linus Torvalds; +Cc: linux-kernel, linux-mips, KOSAKI Motohiro, James Morris

> commit b0ae19811375031ae3b3fecc65b702a9c6e5cc28
> Author: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
> Date:   Fri Oct 15 04:21:18 2010 +0900
>
>     security: remove unused parameter from security_task_setscheduler()

broke the build of arch/mips/kernel/mips-mt-fpaff.c.  The function
arguments were unnecessary, not the semicolon ...

Signed-off-by: Ralf Baechle <ralf@linux-mips.org>

 arch/mips/kernel/mips-mt-fpaff.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/mips/kernel/mips-mt-fpaff.c b/arch/mips/kernel/mips-mt-fpaff.c
index 9a526ba..802e616 100644
--- a/arch/mips/kernel/mips-mt-fpaff.c
+++ b/arch/mips/kernel/mips-mt-fpaff.c
@@ -103,7 +103,7 @@ asmlinkage long mipsmt_sys_sched_setaffinity(pid_t pid, unsigned int len,
 	if (!check_same_owner(p) && !capable(CAP_SYS_NICE))
 		goto out_unlock;
 
-	retval = security_task_setscheduler(p)
+	retval = security_task_setscheduler(p);
 	if (retval)
 		goto out_unlock;
 

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] MIPS: MT: Fix build error iFPU affinity code
  2010-10-24 21:23 [PATCH] MIPS: MT: Fix build error iFPU affinity code Ralf Baechle
@ 2010-10-25  0:40 ` KOSAKI Motohiro
  2010-10-25 10:15 ` James Morris
  1 sibling, 0 replies; 3+ messages in thread
From: KOSAKI Motohiro @ 2010-10-25  0:40 UTC (permalink / raw)
  To: Ralf Baechle
  Cc: kosaki.motohiro, Linus Torvalds, linux-kernel, linux-mips,
	James Morris

> > commit b0ae19811375031ae3b3fecc65b702a9c6e5cc28
> > Author: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
> > Date:   Fri Oct 15 04:21:18 2010 +0900
> >
> >     security: remove unused parameter from security_task_setscheduler()
> 
> broke the build of arch/mips/kernel/mips-mt-fpaff.c.  The function
> arguments were unnecessary, not the semicolon ...
> 
> Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
> 
>  arch/mips/kernel/mips-mt-fpaff.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/mips/kernel/mips-mt-fpaff.c b/arch/mips/kernel/mips-mt-fpaff.c
> index 9a526ba..802e616 100644
> --- a/arch/mips/kernel/mips-mt-fpaff.c
> +++ b/arch/mips/kernel/mips-mt-fpaff.c
> @@ -103,7 +103,7 @@ asmlinkage long mipsmt_sys_sched_setaffinity(pid_t pid, unsigned int len,
>  	if (!check_same_owner(p) && !capable(CAP_SYS_NICE))
>  		goto out_unlock;
>  
> -	retval = security_task_setscheduler(p)
> +	retval = security_task_setscheduler(p);
>  	if (retval)
>  		goto out_unlock;
>  

Agh! Thank you for fixing this!

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] MIPS: MT: Fix build error iFPU affinity code
  2010-10-24 21:23 [PATCH] MIPS: MT: Fix build error iFPU affinity code Ralf Baechle
  2010-10-25  0:40 ` KOSAKI Motohiro
@ 2010-10-25 10:15 ` James Morris
  1 sibling, 0 replies; 3+ messages in thread
From: James Morris @ 2010-10-25 10:15 UTC (permalink / raw)
  To: Ralf Baechle; +Cc: Linus Torvalds, linux-kernel, linux-mips, KOSAKI Motohiro

On Sun, 24 Oct 2010, Ralf Baechle wrote:

> > commit b0ae19811375031ae3b3fecc65b702a9c6e5cc28
> > Author: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
> > Date:   Fri Oct 15 04:21:18 2010 +0900
> >
> >     security: remove unused parameter from security_task_setscheduler()
> 
> broke the build of arch/mips/kernel/mips-mt-fpaff.c.  The function
> arguments were unnecessary, not the semicolon ...
> 
> Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
> 
>  arch/mips/kernel/mips-mt-fpaff.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)

Acked-by: James Morris <jmorris@namei.org>


> 
> diff --git a/arch/mips/kernel/mips-mt-fpaff.c b/arch/mips/kernel/mips-mt-fpaff.c
> index 9a526ba..802e616 100644
> --- a/arch/mips/kernel/mips-mt-fpaff.c
> +++ b/arch/mips/kernel/mips-mt-fpaff.c
> @@ -103,7 +103,7 @@ asmlinkage long mipsmt_sys_sched_setaffinity(pid_t pid, unsigned int len,
>  	if (!check_same_owner(p) && !capable(CAP_SYS_NICE))
>  		goto out_unlock;
>  
> -	retval = security_task_setscheduler(p)
> +	retval = security_task_setscheduler(p);
>  	if (retval)
>  		goto out_unlock;
>  
> 

-- 
James Morris
<jmorris@namei.org>

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2010-10-25 10:15 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-10-24 21:23 [PATCH] MIPS: MT: Fix build error iFPU affinity code Ralf Baechle
2010-10-25  0:40 ` KOSAKI Motohiro
2010-10-25 10:15 ` James Morris

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.