From: Alasdair G Kergon <agk@redhat.com>
To: lvm-devel@redhat.com
Subject: [RFC][PATCH] never scan a device which is using the error target
Date: Mon, 25 Oct 2010 02:00:31 +0100 [thread overview]
Message-ID: <20101025010031.GA26942@agk-dp.fab.redhat.com> (raw)
In-Reply-To: <20101024005515.GA31723@redhat.com>
On Sat, Oct 23, 2010 at 08:55:15PM -0400, Mike Snitzer wrote:
> any device using the error target shouldn't be scanned.
I disagree with that:)
Scanning an error target does not cause the system to lock up so, in general,
there's no reason not to scan it.
(Remember that the error target might only be used in 1 out of hundreds
of table lines and that loop - as you'd expect for the current uses - skips the
device if *any* target matches.)
The defining characteristic here is surely that the device is no longer
meant to be available for mounting - no longer visible, in other words.
So you may (for now) need a more specific test that's limited
to snapshot merge.
Alasdair
next prev parent reply other threads:[~2010-10-25 1:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-24 0:55 [RFC][PATCH] never scan a device which is using the error target Mike Snitzer
2010-10-24 16:43 ` Milan Broz
2010-10-24 17:28 ` Mike Snitzer
2010-10-25 1:00 ` Alasdair G Kergon [this message]
2010-10-25 1:23 ` Mike Snitzer
2010-10-25 1:24 ` Alasdair G Kergon
2010-10-25 6:19 ` Milan Broz
2010-10-25 18:59 ` Alasdair G Kergon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101025010031.GA26942@agk-dp.fab.redhat.com \
--to=agk@redhat.com \
--cc=lvm-devel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.