From: Milan Broz <mbroz@redhat.com>
To: lvm-devel@redhat.com
Subject: [RFC][PATCH] never scan a device which is using the error target
Date: Mon, 25 Oct 2010 08:19:11 +0200 [thread overview]
Message-ID: <4CC5215F.4080304@redhat.com> (raw)
In-Reply-To: <20101025010031.GA26942@agk-dp.fab.redhat.com>
On 10/25/2010 03:00 AM, Alasdair G Kergon wrote:
> So you may (for now) need a more specific test that's limited
> to snapshot merge.
ok. But with this approach we will have just code full of strange
exceptions.
I thought about "error" device as replacement for "failed" device,
so with this definition it should not be scanned or used.
But we are now apparently using error device as some padding
in intermediate state...
Just ad idea: should not be here special alias for it?
Like "failed" target + "error" target?
The logic "what if error is just one line in table" - the logic
is wrong there already - what if mirror is just part of table?
Now is excluded completely.
Also "suspended" state is state for LUKS device after luksSuspend,
(with volume key wiped) should I add another special exception for that?
...
Isn't there some better approach? Last 2 or 3 deadlocks with
clusters were caused by this code too, seems like candidate for rewrite:)
Milan
next prev parent reply other threads:[~2010-10-25 6:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-24 0:55 [RFC][PATCH] never scan a device which is using the error target Mike Snitzer
2010-10-24 16:43 ` Milan Broz
2010-10-24 17:28 ` Mike Snitzer
2010-10-25 1:00 ` Alasdair G Kergon
2010-10-25 1:23 ` Mike Snitzer
2010-10-25 1:24 ` Alasdair G Kergon
2010-10-25 6:19 ` Milan Broz [this message]
2010-10-25 18:59 ` Alasdair G Kergon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CC5215F.4080304@redhat.com \
--to=mbroz@redhat.com \
--cc=lvm-devel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.