From: Jeff Layton <jlayton@samba.org>
To: Dan Carpenter <error27-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Steve French <sfrench-eUNUBHrolfbYtjvyW6yDsg@public.gmane.org>,
Suresh Jayaraman <sjayaraman-l3A5Bk7waGM@public.gmane.org>,
Shirish Pargaonkar
<shirishpargaonkar-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
samba-technical-w/Ol4Ecudpl8XjKLYN78aQ@public.gmane.org,
kernel-janitors-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [patch] cifs: cifs_convert_address() returns zero on error
Date: Mon, 25 Oct 2010 15:31:35 +0000 [thread overview]
Message-ID: <20101025113135.152f52ee@corrin.poochiereds.net> (raw)
In-Reply-To: <20101025050256.GX5985@bicker>
On Mon, 25 Oct 2010 07:02:56 +0200
Dan Carpenter <error27@gmail.com> wrote:
> The cifs_convert_address() returns zero on error but this caller is
> testing for negative returns.
>
> Btw. "i" is unsigned here, so it's never negative.
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
>
> diff --git a/fs/cifs/connect.c b/fs/cifs/connect.c
> index 7e73176..ad6a4ea 100644
> --- a/fs/cifs/connect.c
> +++ b/fs/cifs/connect.c
> @@ -1064,7 +1064,7 @@ cifs_parse_mount_options(char *options, const char *devname,
> }
> i = cifs_convert_address((struct sockaddr *)&vol->srcaddr,
> value, strlen(value));
> - if (i < 0) {
> + if (i = 0) {
> printk(KERN_WARNING "CIFS: Could not parse"
> " srcaddr: %s\n",
> value);
> --
> To unsubscribe from this list: send the line "unsubscribe linux-cifs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
Good catch. Looks right to me.
Reviewed-by:
--
Jeff Layton <jlayton@samba.org>
WARNING: multiple messages have this Message-ID (diff)
From: Jeff Layton <jlayton-eUNUBHrolfbYtjvyW6yDsg@public.gmane.org>
To: Dan Carpenter <error27-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Steve French <sfrench-eUNUBHrolfbYtjvyW6yDsg@public.gmane.org>,
Suresh Jayaraman <sjayaraman-l3A5Bk7waGM@public.gmane.org>,
Shirish Pargaonkar
<shirishpargaonkar-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
samba-technical-w/Ol4Ecudpl8XjKLYN78aQ@public.gmane.org,
kernel-janitors-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [patch] cifs: cifs_convert_address() returns zero on error
Date: Mon, 25 Oct 2010 11:31:35 -0400 [thread overview]
Message-ID: <20101025113135.152f52ee@corrin.poochiereds.net> (raw)
In-Reply-To: <20101025050256.GX5985@bicker>
On Mon, 25 Oct 2010 07:02:56 +0200
Dan Carpenter <error27-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
> The cifs_convert_address() returns zero on error but this caller is
> testing for negative returns.
>
> Btw. "i" is unsigned here, so it's never negative.
>
> Signed-off-by: Dan Carpenter <error27-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
>
> diff --git a/fs/cifs/connect.c b/fs/cifs/connect.c
> index 7e73176..ad6a4ea 100644
> --- a/fs/cifs/connect.c
> +++ b/fs/cifs/connect.c
> @@ -1064,7 +1064,7 @@ cifs_parse_mount_options(char *options, const char *devname,
> }
> i = cifs_convert_address((struct sockaddr *)&vol->srcaddr,
> value, strlen(value));
> - if (i < 0) {
> + if (i == 0) {
> printk(KERN_WARNING "CIFS: Could not parse"
> " srcaddr: %s\n",
> value);
> --
> To unsubscribe from this list: send the line "unsubscribe linux-cifs" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
Good catch. Looks right to me.
Reviewed-by:
--
Jeff Layton <jlayton-eUNUBHrolfbYtjvyW6yDsg@public.gmane.org>
next prev parent reply other threads:[~2010-10-25 15:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-25 5:02 [patch] cifs: cifs_convert_address() returns zero on error Dan Carpenter
2010-10-25 5:02 ` Dan Carpenter
2010-10-25 15:31 ` Jeff Layton [this message]
2010-10-25 15:31 ` Jeff Layton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101025113135.152f52ee@corrin.poochiereds.net \
--to=jlayton@samba.org \
--cc=error27-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=kernel-janitors-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=samba-technical-w/Ol4Ecudpl8XjKLYN78aQ@public.gmane.org \
--cc=sfrench-eUNUBHrolfbYtjvyW6yDsg@public.gmane.org \
--cc=shirishpargaonkar-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=sjayaraman-l3A5Bk7waGM@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.