From: Richard Weinberger <richard@nod.at>
To: Andrew Morton <akpm@linux-foundation.org>, xiyou.wangcong@gmail.com
Cc: dhowells@redhat.com, jkosina@suse.cz, jdike@addtoit.com,
linux-kernel@vger.kernel.org,
user-mode-linux-devel@lists.sourceforge.net
Subject: Re: [uml-devel] [PATCH] um: Fix IRQ flag handling naming
Date: Mon, 25 Oct 2010 21:38:26 +0200 [thread overview]
Message-ID: <201010252138.27096.richard@nod.at> (raw)
In-Reply-To: <20101025122936.56d0370f.akpm@linux-foundation.org>
Am Montag 25 Oktober 2010, 21:29:36 schrieb Andrew Morton:
> On Mon, 25 Oct 2010 17:24:33 +0200
>
> Richard Weinberger <richard@nod.at> wrote:
> > Commit df9ee292 changed the IRQ flag handling naming scheme
> > and broke UML.
> > This patch brings the new scheme to UML and makes it work again.
>
> Please always fully describe a bug when fixing it. Something more than
> "broke". In the case of compilation errors or warnings, that means
> quoting the compiler error output and, if necessary, the means of
> reproducing it (config, compiler version, etc).
Sorry!
I forgot to add the LKML-Reference to my initial report.
LKML-Reference: <201010190141.10365.richard () nod ! at>
> I did an allnoconfig uml build and saw this:
>
> In file included from /usr/src/25/arch/um/include/asm/fixmap.h:5,
> from /usr/src/25/arch/um/include/shared/um_uaccess.h:10,
> from /usr/src/25/arch/um/include/asm/uaccess.h:41,
> from /usr/src/25/arch/um/include/asm/thread_info.h:13,
> from include/linux/thread_info.h:56,
> from include/linux/preempt.h:9,
> from include/linux/spinlock.h:50,
> from include/linux/seqlock.h:29,
> from include/linux/time.h:8,
> from include/linux/stat.h:60,
> from include/linux/module.h:10,
> from init/main.c:13:
> /usr/src/25/arch/um/include/asm/system.h:11:1: warning: "local_save_flags"
> redefined
>
> which I shall assume is the error which this patch addresses.
Yes, this is the error.
Thanks,
//richard
------------------------------------------------------------------------------
Nokia and AT&T present the 2010 Calling All Innovators-North America contest
Create new apps & games for the Nokia N8 for consumers in U.S. and Canada
$10 million total in prizes - $4M cash, 500 devices, nearly $6M in marketing
Develop with Nokia Qt SDK, Web Runtime, or Java and Publish to Ovi Store
http://p.sf.net/sfu/nokia-dev2dev
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel
WARNING: multiple messages have this Message-ID (diff)
From: Richard Weinberger <richard@nod.at>
To: Andrew Morton <akpm@linux-foundation.org>, xiyou.wangcong@gmail.com
Cc: linux-kernel@vger.kernel.org, jdike@addtoit.com,
user-mode-linux-devel@lists.sourceforge.net, dhowells@redhat.com,
jkosina@suse.cz
Subject: Re: [PATCH] um: Fix IRQ flag handling naming
Date: Mon, 25 Oct 2010 21:38:26 +0200 [thread overview]
Message-ID: <201010252138.27096.richard@nod.at> (raw)
In-Reply-To: <20101025122936.56d0370f.akpm@linux-foundation.org>
Am Montag 25 Oktober 2010, 21:29:36 schrieb Andrew Morton:
> On Mon, 25 Oct 2010 17:24:33 +0200
>
> Richard Weinberger <richard@nod.at> wrote:
> > Commit df9ee292 changed the IRQ flag handling naming scheme
> > and broke UML.
> > This patch brings the new scheme to UML and makes it work again.
>
> Please always fully describe a bug when fixing it. Something more than
> "broke". In the case of compilation errors or warnings, that means
> quoting the compiler error output and, if necessary, the means of
> reproducing it (config, compiler version, etc).
Sorry!
I forgot to add the LKML-Reference to my initial report.
LKML-Reference: <201010190141.10365.richard () nod ! at>
> I did an allnoconfig uml build and saw this:
>
> In file included from /usr/src/25/arch/um/include/asm/fixmap.h:5,
> from /usr/src/25/arch/um/include/shared/um_uaccess.h:10,
> from /usr/src/25/arch/um/include/asm/uaccess.h:41,
> from /usr/src/25/arch/um/include/asm/thread_info.h:13,
> from include/linux/thread_info.h:56,
> from include/linux/preempt.h:9,
> from include/linux/spinlock.h:50,
> from include/linux/seqlock.h:29,
> from include/linux/time.h:8,
> from include/linux/stat.h:60,
> from include/linux/module.h:10,
> from init/main.c:13:
> /usr/src/25/arch/um/include/asm/system.h:11:1: warning: "local_save_flags"
> redefined
>
> which I shall assume is the error which this patch addresses.
Yes, this is the error.
Thanks,
//richard
next prev parent reply other threads:[~2010-10-25 19:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-25 15:24 [PATCH] um: Fix IRQ flag handling naming Richard Weinberger
2010-10-25 19:29 ` [uml-devel] " Andrew Morton
2010-10-25 19:29 ` Andrew Morton
2010-10-25 19:38 ` Richard Weinberger [this message]
2010-10-25 19:38 ` Richard Weinberger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201010252138.27096.richard@nod.at \
--to=richard@nod.at \
--cc=akpm@linux-foundation.org \
--cc=dhowells@redhat.com \
--cc=jdike@addtoit.com \
--cc=jkosina@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=user-mode-linux-devel@lists.sourceforge.net \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.