All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mike Frysinger <vapier@gentoo.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] cmd_net: drop spurious comma in U_BOOT_CMD
Date: Tue, 26 Oct 2010 20:45:35 -0400	[thread overview]
Message-ID: <201010262045.36523.vapier@gentoo.org> (raw)
In-Reply-To: <20101026214510.7AB5F1365D8@gemini.denx.de>

On Tuesday, October 26, 2010 17:45:10 Wolfgang Denk wrote:
> In message <20101026191510.5AC28152451@gemini.denx.de> I wrote:
> > Mike Frysinger wrote:
> > > Building for boards that have CONFIG_CMD_CDP enabled fail with:
> > > cmd_net.c:301: error: expected expression before ',' token
> > 
> > Applied, thanks.
> 
> I wish I had tested this before applying - and even more I wish you
> had run MAKEALL as requested when sumbitting patches.

actually, as i had stated in one of my other patches, i *was* running MAKEALL 
but the vast majority of boards were failing (probably because of your patches 
you noted some time later).  for the few boards that didnt fail in that way, 
they were failing *because of this code*.

i wrote the patch *because* MAKEALL was reporting failures due to this code.  
but perhaps the failure i was seeing was just fallout of the bad patches you 
had pushed already.  i guess i dont really care because none of my boards were 
or are failing due to this, and i'll stop trying to fix other people's board 
failures.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20101026/ed655b40/attachment.pgp 

      reply	other threads:[~2010-10-27  0:45 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-20  7:33 [U-Boot] [PATCH] cmd_net: drop spurious comma in U_BOOT_CMD Mike Frysinger
2010-10-26 19:15 ` Wolfgang Denk
2010-10-26 21:45   ` Wolfgang Denk
2010-10-27  0:45     ` Mike Frysinger [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201010262045.36523.vapier@gentoo.org \
    --to=vapier@gentoo.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.