All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] cmd_net: drop spurious comma in U_BOOT_CMD
Date: Tue, 26 Oct 2010 23:45:10 +0200	[thread overview]
Message-ID: <20101026214510.7AB5F1365D8@gemini.denx.de> (raw)
In-Reply-To: <20101026191510.5AC28152451@gemini.denx.de>

In message <20101026191510.5AC28152451@gemini.denx.de> I wrote:
> Dear Mike Frysinger,
> 
> In message <1287560010-31252-1-git-send-email-vapier@gentoo.org> you wrote:
> > Building for boards that have CONFIG_CMD_CDP enabled fail with:
> > cmd_net.c:301: error: expected expression before ',' token
> > 
> > Signed-off-by: Mike Frysinger <vapier@gentoo.org>
> > ---
> >  common/cmd_net.c |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> Applied, thanks.

I wish I had tested this before applying - and even more I wish you
had run MAKEALL as requested when sumbitting patches.

Reverted, as it breaks building of some boards:

Configuring for LANTEC board...
cmd_net.c:301:1: error: macro "U_BOOT_CMD" requires 6 arguments, but only 5 given
cmd_net.c:298: warning: data definition has no type or storage class
cmd_net.c:298: warning: type defaults to 'int' in declaration of 'U_BOOT_CMD'
make[1]: *** [/work/wd/tmp-ppc/common/cmd_net.o] Error 1


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Unsichtbar macht sich die Dummheit, indem sie immer  gr??ere  Ausma?e
annimmt.                             -- Bertold Brecht: Der Tui-Roman

  reply	other threads:[~2010-10-26 21:45 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-20  7:33 [U-Boot] [PATCH] cmd_net: drop spurious comma in U_BOOT_CMD Mike Frysinger
2010-10-26 19:15 ` Wolfgang Denk
2010-10-26 21:45   ` Wolfgang Denk [this message]
2010-10-27  0:45     ` Mike Frysinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101026214510.7AB5F1365D8@gemini.denx.de \
    --to=wd@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.