From: Dan Carpenter <error27@gmail.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Henrik Rydberg <rydberg@euromail.se>,
Naveen Kumar Gaddipati <naveen.gaddipati@stericsson.com>,
Linus Walleij <linus.walleij@stericsson.com>,
linux-input@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: [patch v2] touchscreen/bu21013_ts: null dereference in error
Date: Wed, 27 Oct 2010 20:26:05 +0000 [thread overview]
Message-ID: <20101027202605.GH6062@bicker> (raw)
In-Reply-To: <20101027154613.GA8745@core.coreip.homeip.net>
In the original code "bu21013_data" could be NULL here.
Signed-off-by: Dan Carpenter <error27@gmail.com>
---
V2: same thing; different approach.
diff --git a/drivers/input/touchscreen/bu21013_ts.c b/drivers/input/touchscreen/bu21013_ts.c
index ccde586..2ca9e5d 100644
--- a/drivers/input/touchscreen/bu21013_ts.c
+++ b/drivers/input/touchscreen/bu21013_ts.c
@@ -514,7 +514,7 @@ err_free_irq:
err_cs_disable:
pdata->cs_dis(pdata->cs_pin);
err_free_mem:
- input_free_device(bu21013_data->in_dev);
+ input_free_device(in_dev);
kfree(bu21013_data);
return error;
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <error27@gmail.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Henrik Rydberg <rydberg@euromail.se>,
Naveen Kumar Gaddipati <naveen.gaddipati@stericsson.com>,
Linus Walleij <linus.walleij@stericsson.com>,
linux-input@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: [patch v2] touchscreen/bu21013_ts: null dereference in error handling
Date: Wed, 27 Oct 2010 22:26:05 +0200 [thread overview]
Message-ID: <20101027202605.GH6062@bicker> (raw)
In-Reply-To: <20101027154613.GA8745@core.coreip.homeip.net>
In the original code "bu21013_data" could be NULL here.
Signed-off-by: Dan Carpenter <error27@gmail.com>
---
V2: same thing; different approach.
diff --git a/drivers/input/touchscreen/bu21013_ts.c b/drivers/input/touchscreen/bu21013_ts.c
index ccde586..2ca9e5d 100644
--- a/drivers/input/touchscreen/bu21013_ts.c
+++ b/drivers/input/touchscreen/bu21013_ts.c
@@ -514,7 +514,7 @@ err_free_irq:
err_cs_disable:
pdata->cs_dis(pdata->cs_pin);
err_free_mem:
- input_free_device(bu21013_data->in_dev);
+ input_free_device(in_dev);
kfree(bu21013_data);
return error;
next prev parent reply other threads:[~2010-10-27 20:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-27 10:08 [patch] touchscreen/bu21013_ts: null dereference in error handling Dan Carpenter
2010-10-27 10:08 ` Dan Carpenter
2010-10-27 15:46 ` [patch] touchscreen/bu21013_ts: null dereference in error Dmitry Torokhov
2010-10-27 15:46 ` [patch] touchscreen/bu21013_ts: null dereference in error handling Dmitry Torokhov
2010-10-27 20:26 ` Dan Carpenter [this message]
2010-10-27 20:26 ` [patch v2] " Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101027202605.GH6062@bicker \
--to=error27@gmail.com \
--cc=dmitry.torokhov@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linus.walleij@stericsson.com \
--cc=linux-input@vger.kernel.org \
--cc=naveen.gaddipati@stericsson.com \
--cc=rydberg@euromail.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.