From: Dan Carpenter <error27@gmail.com>
To: "J. Bruce Fields" <bfields@fieldses.org>
Cc: Neil Brown <neilb@suse.de>,
linux-nfs@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] nfsd: fix NULL dereference in setattr()
Date: Wed, 27 Oct 2010 22:20:37 +0000 [thread overview]
Message-ID: <20101027222037.GO6062@bicker> (raw)
In-Reply-To: <20101027215025.GB29477@fieldses.org>
On Wed, Oct 27, 2010 at 05:50:25PM -0400, J. Bruce Fields wrote:
> On Wed, Oct 27, 2010 at 11:19:04PM +0200, Dan Carpenter wrote:
> > The original code would oops if this were called from nfsd4_setattr()
> > because "filpp" is NULL.
>
> I believe it's impossible to reach this case: we never give out write
> delegations, so the preceding nfs4_check_delegmode will always fail when
> called from setattr.
>
> We should do this anyway, but I'll probably queue it up for the next
> merge window.
Sounds good. This was a static checker patch not a run time bug (as
you obviously realized).
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <error27@gmail.com>
To: "J. Bruce Fields" <bfields@fieldses.org>
Cc: Neil Brown <neilb@suse.de>,
linux-nfs@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] nfsd: fix NULL dereference in setattr()
Date: Thu, 28 Oct 2010 00:20:37 +0200 [thread overview]
Message-ID: <20101027222037.GO6062@bicker> (raw)
In-Reply-To: <20101027215025.GB29477@fieldses.org>
On Wed, Oct 27, 2010 at 05:50:25PM -0400, J. Bruce Fields wrote:
> On Wed, Oct 27, 2010 at 11:19:04PM +0200, Dan Carpenter wrote:
> > The original code would oops if this were called from nfsd4_setattr()
> > because "filpp" is NULL.
>
> I believe it's impossible to reach this case: we never give out write
> delegations, so the preceding nfs4_check_delegmode will always fail when
> called from setattr.
>
> We should do this anyway, but I'll probably queue it up for the next
> merge window.
Sounds good. This was a static checker patch not a run time bug (as
you obviously realized).
regards,
dan carpenter
next prev parent reply other threads:[~2010-10-27 22:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-27 21:19 [patch] nfsd: fix NULL dereference in setattr() Dan Carpenter
2010-10-27 21:19 ` Dan Carpenter
2010-10-27 21:50 ` J. Bruce Fields
2010-10-27 21:50 ` J. Bruce Fields
2010-10-27 22:20 ` Dan Carpenter [this message]
2010-10-27 22:20 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101027222037.GO6062@bicker \
--to=error27@gmail.com \
--cc=bfields@fieldses.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=neilb@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.