* [patch] misc/isl29020: signedness bug in als_sensing_range_store()
@ 2010-10-28 4:40 ` Dan Carpenter
0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2010-10-28 4:40 UTC (permalink / raw)
To: Liu Hong; +Cc: Kalhan Trisal, Alan Cox, linux-kernel, kernel-janitors
"ret_val" is supposed to be signed here or the error handling breaks.
Also we should check the return value from i2c_smbus_read_byte_data().
Signed-off-by: Dan Carpenter <error27@gmail.com>
diff --git a/drivers/misc/isl29020.c b/drivers/misc/isl29020.c
index 34fe835..ca47e62 100644
--- a/drivers/misc/isl29020.c
+++ b/drivers/misc/isl29020.c
@@ -87,7 +87,7 @@ static ssize_t als_sensing_range_store(struct device *dev,
struct device_attribute *attr, const char *buf, size_t count)
{
struct i2c_client *client = to_i2c_client(dev);
- unsigned int ret_val;
+ int ret_val;
unsigned long val;
if (strict_strtoul(buf, 10, &val))
@@ -106,6 +106,8 @@ static ssize_t als_sensing_range_store(struct device *dev,
val = 4;
ret_val = i2c_smbus_read_byte_data(client, 0x00);
+ if (ret_val < 0)
+ return ret_val;
ret_val &= 0xFC; /*reset the bit before setting them */
ret_val |= val - 1;
^ permalink raw reply related [flat|nested] 4+ messages in thread* [patch] misc/isl29020: signedness bug in als_sensing_range_store()
@ 2010-10-28 4:40 ` Dan Carpenter
0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2010-10-28 4:40 UTC (permalink / raw)
To: Liu Hong; +Cc: Kalhan Trisal, Alan Cox, linux-kernel, kernel-janitors
"ret_val" is supposed to be signed here or the error handling breaks.
Also we should check the return value from i2c_smbus_read_byte_data().
Signed-off-by: Dan Carpenter <error27@gmail.com>
diff --git a/drivers/misc/isl29020.c b/drivers/misc/isl29020.c
index 34fe835..ca47e62 100644
--- a/drivers/misc/isl29020.c
+++ b/drivers/misc/isl29020.c
@@ -87,7 +87,7 @@ static ssize_t als_sensing_range_store(struct device *dev,
struct device_attribute *attr, const char *buf, size_t count)
{
struct i2c_client *client = to_i2c_client(dev);
- unsigned int ret_val;
+ int ret_val;
unsigned long val;
if (strict_strtoul(buf, 10, &val))
@@ -106,6 +106,8 @@ static ssize_t als_sensing_range_store(struct device *dev,
val = 4;
ret_val = i2c_smbus_read_byte_data(client, 0x00);
+ if (ret_val < 0)
+ return ret_val;
ret_val &= 0xFC; /*reset the bit before setting them */
ret_val |= val - 1;
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [patch] misc/isl29020: signedness bug in
2010-10-28 4:40 ` Dan Carpenter
@ 2010-11-09 13:44 ` Alan Cox
-1 siblings, 0 replies; 4+ messages in thread
From: Alan Cox @ 2010-11-09 13:44 UTC (permalink / raw)
To: Dan Carpenter
Cc: Liu Hong, Kalhan Trisal, Alan Cox, linux-kernel, kernel-janitors
On Thu, 28 Oct 2010 06:40:37 +0200
Dan Carpenter <error27@gmail.com> wrote:
> misc/isl29020: signedness bug in als_sensing_range_store()
Thanks - added to my tree
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2010-11-09 13:45 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-10-28 4:40 [patch] misc/isl29020: signedness bug in als_sensing_range_store() Dan Carpenter
2010-10-28 4:40 ` Dan Carpenter
2010-11-09 13:44 ` [patch] misc/isl29020: signedness bug in Alan Cox
2010-11-09 13:44 ` [patch] misc/isl29020: signedness bug in als_sensing_range_store() Alan Cox
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.