From: Andi Kleen <ak@linux.intel.com>
To: Boaz Harrosh <bharrosh@panasas.com>
Cc: James Bottomley <James.Bottomley@suse.de>,
"Nicholas A. Bellinger" <nab@linux-iscsi.org>,
Mike Anderson <andmike@linux.vnet.ibm.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
linux-scsi <linux-scsi@vger.kernel.org>,
Vasu Dev <vasu.dev@linux.intel.com>,
Tim Chen <tim.c.chen@linux.intel.com>,
Matthew Wilcox <willy@linux.intel.com>,
Mike Christie <michaelc@cs.wisc.edu>,
Jens Axboe <jaxboe@fusionio.com>,
James Smart <james.smart@emulex.com>,
Andrew Vasquez <andrew.vasquez@qlogic.com>,
FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>,
Hannes Reinecke <hare@suse.de>, Joe Eykholt <jeykholt@cisco.com>,
Christoph Hellwig <hch@lst.de>, Jon Hawley <warthog9@kernel.org>,
Brian King <brking@linux.vnet.ibm.com>,
Christof Schmitt <christof.schmitt@de.ibm.com>,
Tejun Heo <tj@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
"H. Peter Anvin" <hpa@zytor.com>,
julia@diku.d
Subject: Re: [ANNOUNCE] Status of unlocked_qcmds=1 operation for .37
Date: Thu, 28 Oct 2010 20:26:10 +0200 [thread overview]
Message-ID: <20101028182610.GA4592@gargoyle.fritz.box> (raw)
In-Reply-To: <4CC95BE8.3000909@panasas.com>
> I disagree with your approach this introduces a spin_unlock_irqrestore
> call site at every return, in the usually huge queuecommand.
I converted the full tree and in practice it turns out there
are very few returns in nearly all queuecommands. So it won't
make much difference.
Longer term they will be all hopefully gone again anyways.
-Andi
WARNING: multiple messages have this Message-ID (diff)
From: Andi Kleen <ak@linux.intel.com>
To: Boaz Harrosh <bharrosh@panasas.com>
Cc: James Bottomley <James.Bottomley@suse.de>,
"Nicholas A. Bellinger" <nab@linux-iscsi.org>,
Mike Anderson <andmike@linux.vnet.ibm.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
linux-scsi <linux-scsi@vger.kernel.org>,
Vasu Dev <vasu.dev@linux.intel.com>,
Tim Chen <tim.c.chen@linux.intel.com>,
Matthew Wilcox <willy@linux.intel.com>,
Mike Christie <michaelc@cs.wisc.edu>,
Jens Axboe <jaxboe@fusionio.com>,
James Smart <james.smart@emulex.com>,
Andrew Vasquez <andrew.vasquez@qlogic.com>,
FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>,
Hannes Reinecke <hare@suse.de>, Joe Eykholt <jeykholt@cisco.com>,
Christoph Hellwig <hch@lst.de>, Jon Hawley <warthog9@kernel.org>,
Brian King <brking@linux.vnet.ibm.com>,
Christof Schmitt <christof.schmitt@de.ibm.com>,
Tejun Heo <tj@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
"H. Peter Anvin" <hpa@zytor.com>,
julia@diku.dk
Subject: Re: [ANNOUNCE] Status of unlocked_qcmds=1 operation for .37
Date: Thu, 28 Oct 2010 20:26:10 +0200 [thread overview]
Message-ID: <20101028182610.GA4592@gargoyle.fritz.box> (raw)
In-Reply-To: <4CC95BE8.3000909@panasas.com>
> I disagree with your approach this introduces a spin_unlock_irqrestore
> call site at every return, in the usually huge queuecommand.
I converted the full tree and in practice it turns out there
are very few returns in nearly all queuecommands. So it won't
make much difference.
Longer term they will be all hopefully gone again anyways.
-Andi
next prev parent reply other threads:[~2010-10-28 18:26 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-20 20:49 [ANNOUNCE] Status of unlocked_qcmds=1 operation for .37 Nicholas A. Bellinger
2010-10-20 20:49 ` Nicholas A. Bellinger
2010-10-21 19:26 ` Luben Tuikov
2010-10-21 19:26 ` Luben Tuikov
[not found] ` <20101021150840.GA24309@linux.vnet.ibm.com>
2010-10-26 22:08 ` Nicholas A. Bellinger
2010-10-26 22:27 ` James Bottomley
2010-10-26 22:34 ` Nicholas A. Bellinger
2010-10-26 22:50 ` James Bottomley
2010-10-26 23:00 ` Nicholas A. Bellinger
2010-10-26 23:11 ` James Bottomley
2010-10-26 23:31 ` Nicholas A. Bellinger
2010-10-27 7:53 ` Andi Kleen
2010-10-27 14:27 ` James Bottomley
2010-10-27 18:06 ` Nicholas A. Bellinger
2010-10-27 18:16 ` James Bottomley
2010-10-27 19:20 ` Mike Anderson
2010-10-27 19:55 ` Nicholas A. Bellinger
2010-10-27 23:28 ` Jeff Garzik
2010-10-28 9:10 ` Andi Kleen
2010-10-28 11:18 ` Boaz Harrosh
2010-10-28 11:18 ` Boaz Harrosh
2010-10-28 18:26 ` Andi Kleen [this message]
2010-10-28 18:26 ` Andi Kleen
2010-10-31 12:14 ` Boaz Harrosh
2010-10-31 12:14 ` Boaz Harrosh
2010-11-01 11:45 ` Andi Kleen
2010-11-01 11:45 ` Andi Kleen
2010-10-28 20:27 ` Nicholas A. Bellinger
2010-10-29 7:50 ` Andi Kleen
2010-10-29 23:50 ` Nicholas A. Bellinger
2010-10-29 23:50 ` Nicholas A. Bellinger
2010-10-29 23:57 ` Nicholas A. Bellinger
2010-10-27 18:03 ` Nicholas A. Bellinger
[not found] <C8E4BD3D.A1E3%giridhar.malavali@qlogic.com>
2010-10-20 23:19 ` Nicholas A. Bellinger
2010-10-21 0:30 ` Giridhar Malavali
2010-10-21 0:39 ` Nicholas A. Bellinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101028182610.GA4592@gargoyle.fritz.box \
--to=ak@linux.intel.com \
--cc=James.Bottomley@suse.de \
--cc=akpm@linux-foundation.org \
--cc=andmike@linux.vnet.ibm.com \
--cc=andrew.vasquez@qlogic.com \
--cc=bharrosh@panasas.com \
--cc=brking@linux.vnet.ibm.com \
--cc=christof.schmitt@de.ibm.com \
--cc=fujita.tomonori@lab.ntt.co.jp \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=hpa@zytor.com \
--cc=james.smart@emulex.com \
--cc=jaxboe@fusionio.com \
--cc=jeykholt@cisco.com \
--cc=julia@diku.d \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=michaelc@cs.wisc.edu \
--cc=nab@linux-iscsi.org \
--cc=tim.c.chen@linux.intel.com \
--cc=tj@kernel.org \
--cc=vasu.dev@linux.intel.com \
--cc=warthog9@kernel.org \
--cc=willy@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.