From: Luis R. Rodriguez <lrodriguez@atheros.com>
To: ath9k-devel@lists.ath9k.org
Subject: [ath9k-devel] [PATCH] ath9k: Clear DMA addresses when buffers are freed.
Date: Thu, 28 Oct 2010 16:36:36 -0700 [thread overview]
Message-ID: <20101028233636.GB2985@tux> (raw)
In-Reply-To: <4CCA0848.7080001@candelatech.com>
On Thu, Oct 28, 2010 at 04:33:28PM -0700, Ben Greear wrote:
> On 10/15/2010 02:29 PM, greearb at candelatech.com wrote:
> > From: Ben Greear<greearb@candelatech.com>
> >
> > Previous patches cleared the pointer to the SKB, but did not
> > clear the DMA addresses. This patch moves the clear logic into
> > a method and makes sure that the DMA addresses are cleared as well.
> >
> > This does not obviously fix any bug, but may make it harder to
> > cause bugs in the future.
>
> I wanted to follow up to see if there was any interest in this patch,
> as it received no comment and has not been accepted upstream.
I'd rather not introduce code unless you know
for sure its doing something useful.
Luis
WARNING: multiple messages have this Message-ID (diff)
From: "Luis R. Rodriguez" <lrodriguez@atheros.com>
To: Ben Greear <greearb@candelatech.com>
Cc: "ath9k-devel@venema.h4ckr.net" <ath9k-devel@venema.h4ckr.net>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: [ath9k-devel] [PATCH] ath9k: Clear DMA addresses when buffers are freed.
Date: Thu, 28 Oct 2010 16:36:36 -0700 [thread overview]
Message-ID: <20101028233636.GB2985@tux> (raw)
In-Reply-To: <4CCA0848.7080001@candelatech.com>
On Thu, Oct 28, 2010 at 04:33:28PM -0700, Ben Greear wrote:
> On 10/15/2010 02:29 PM, greearb@candelatech.com wrote:
> > From: Ben Greear<greearb@candelatech.com>
> >
> > Previous patches cleared the pointer to the SKB, but did not
> > clear the DMA addresses. This patch moves the clear logic into
> > a method and makes sure that the DMA addresses are cleared as well.
> >
> > This does not obviously fix any bug, but may make it harder to
> > cause bugs in the future.
>
> I wanted to follow up to see if there was any interest in this patch,
> as it received no comment and has not been accepted upstream.
I'd rather not introduce code unless you know
for sure its doing something useful.
Luis
next prev parent reply other threads:[~2010-10-28 23:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-15 21:29 [ath9k-devel] [PATCH] ath9k: Clear DMA addresses when buffers are freed greearb at candelatech.com
2010-10-15 21:29 ` greearb
2010-10-28 23:33 ` [ath9k-devel] " Ben Greear
2010-10-28 23:33 ` Ben Greear
2010-10-28 23:36 ` Luis R. Rodriguez [this message]
2010-10-28 23:36 ` [ath9k-devel] " Luis R. Rodriguez
2010-10-28 23:44 ` Ben Greear
2010-10-28 23:44 ` Ben Greear
2010-10-29 5:12 ` Peter Stuge
2010-10-29 13:21 ` John W. Linville
2010-10-29 13:21 ` John W. Linville
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101028233636.GB2985@tux \
--to=lrodriguez@atheros.com \
--cc=ath9k-devel@lists.ath9k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.