From: "Pasi Kärkkäinen" <pasik@iki.fi>
To: Keir Fraser <keir@xen.org>
Cc: anthony.perard@citrix.com, Xen Devel <xen-devel@lists.xensource.com>
Subject: Re: [PATCH V3 0/6] firmware changes as part of QEMU/Xen merge.
Date: Fri, 29 Oct 2010 16:27:42 +0300 [thread overview]
Message-ID: <20101029132742.GO2804@reaktio.net> (raw)
In-Reply-To: <C8F08835.8A8E%keir@xen.org>
On Fri, Oct 29, 2010 at 02:18:29PM +0100, Keir Fraser wrote:
> On 29/10/2010 14:16, "Keir Fraser" <keir@xen.org> wrote:
>
> >> Should it be called something else than HVM_PARAM_ACPI_NEW_IOPORT ?
> >> After a couple of years "NEW" might not make much sense anymore..
> >>
> >> IOPORT_V2 ? Or something..
> >
> > I've asked for a nice big explanatory comment to be added beside the
> > parameter's definition. Also we should treat this field as a version number,
> > so baking a fixed version into its name is not a good idea. With the
> > explanatory comment, I think its existing name is good enough. To do much
> > better the name would have to become cumbersomely long.
>
> That said, HVM_PARAM_ACPI_IOPORTS_LOCATION might be better... I'm not
> personally that fussed either way however.
>
Yeah, that sounds good..
-- Pasi
next prev parent reply other threads:[~2010-10-29 13:27 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-29 12:08 [PATCH V3 0/6] firmware changes as part of QEMU/Xen merge anthony.perard
2010-10-29 12:08 ` [PATCH V3 1/6] firmware, Change ACPI IO addresses and values to match QEMU BIOS anthony.perard
2010-10-29 12:08 ` [PATCH V3 2/6] xen, Introduce unregister_io_handler anthony.perard
2010-10-29 12:08 ` [PATCH V3 3/6] xen, Intruduce pmtimer_change_ioport and HVM_PARAM_ACPI_NEW_IOPORT anthony.perard
2010-10-29 12:25 ` Keir Fraser
2010-10-29 13:09 ` Anthony PERARD
2010-10-29 12:08 ` [PATCH V3 4/6] firmware, Set HVM_PARAM_ACPI_NEW_IOPORT anthony.perard
2010-10-29 12:08 ` [PATCH V3 5/6] libxc, save/restore, Save the HVM_PARAM_ACPI_NEW_IOPORT anthony.perard
2010-10-29 12:08 ` [PATCH V3 6/6] piix4acpi: change in ACPI to match the change in the BIOS anthony.perard
2010-10-29 13:11 ` [PATCH V3 0/6] firmware changes as part of QEMU/Xen merge Pasi Kärkkäinen
2010-10-29 13:16 ` Keir Fraser
2010-10-29 13:18 ` Keir Fraser
2010-10-29 13:27 ` Pasi Kärkkäinen [this message]
2010-10-29 13:42 ` [PATCH V3 0/6] firmware changes as part ofMU/Xen merge Anthony PERARD
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101029132742.GO2804@reaktio.net \
--to=pasik@iki.fi \
--cc=anthony.perard@citrix.com \
--cc=keir@xen.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.