From: Nick Bowler <nbowler@elliptictech.com>
To: Chuck Lever <chuck.lever@oracle.com>
Cc: linux-kernel@vger.kernel.org, linux-nfs@vger.kernel.org
Subject: Re: [PATCH] SUNRPC: Initialize source address if passed-in srcaddr is AF_UNSPEC
Date: Mon, 1 Nov 2010 16:08:22 -0400 [thread overview]
Message-ID: <20101101200822.GA3598@elliptictech.com> (raw)
In-Reply-To: <20101101195631.9279.16018.stgit-RytpoXr2tKZ9HhUboXbp9zCvJB+x5qRC@public.gmane.org>
On 2010-11-01 15:58 -0400, Chuck Lever wrote:
> Recently xs_bind() was changed so it can't tolerate an AF_UNSPEC
> bind address; it needs a fully initialized ANYADDR. We recently fixed
> this case in xprtsock.c, but some upper layer protocols seem to assume
> that it's OK to pass in an AF_UNSPEC address for the source address.
> Catch that case too.
>
> Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
> ---
>
> Untested.
This one seems to correct the issue.
Tested-by: Nick Bowler <nbowler@elliptictech.com>
--
Nick Bowler, Elliptic Technologies (http://www.elliptictech.com/)
WARNING: multiple messages have this Message-ID (diff)
From: Nick Bowler <nbowler@elliptictech.com>
To: Chuck Lever <chuck.lever@oracle.com>
Cc: linux-kernel@vger.kernel.org, linux-nfs@vger.kernel.org
Subject: Re: [PATCH] SUNRPC: Initialize source address if passed-in srcaddr is AF_UNSPEC
Date: Mon, 1 Nov 2010 16:08:22 -0400 [thread overview]
Message-ID: <20101101200822.GA3598@elliptictech.com> (raw)
In-Reply-To: <20101101195631.9279.16018.stgit@matisse.1015granger.net>
On 2010-11-01 15:58 -0400, Chuck Lever wrote:
> Recently xs_bind() was changed so it can't tolerate an AF_UNSPEC
> bind address; it needs a fully initialized ANYADDR. We recently fixed
> this case in xprtsock.c, but some upper layer protocols seem to assume
> that it's OK to pass in an AF_UNSPEC address for the source address.
> Catch that case too.
>
> Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
> ---
>
> Untested.
This one seems to correct the issue.
Tested-by: Nick Bowler <nbowler@elliptictech.com>
--
Nick Bowler, Elliptic Technologies (http://www.elliptictech.com/)
next prev parent reply other threads:[~2010-11-01 20:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-01 19:58 [PATCH] SUNRPC: Initialize source address if passed-in srcaddr is AF_UNSPEC Chuck Lever
[not found] ` <20101101195631.9279.16018.stgit-RytpoXr2tKZ9HhUboXbp9zCvJB+x5qRC@public.gmane.org>
2010-11-01 20:08 ` Nick Bowler [this message]
2010-11-01 20:08 ` Nick Bowler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101101200822.GA3598@elliptictech.com \
--to=nbowler@elliptictech.com \
--cc=chuck.lever@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.