From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Thiago Farina <tfransosi@gmail.com>
Cc: linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org,
patches@opensource.wolfsonmicro.com,
Samuel Ortiz <sameo@linux.intel.com>,
Liam Girdwood <lrg@slimlogic.co.uk>
Subject: Re: [PATCH] mfd: Add initial WM8958 support
Date: Tue, 2 Nov 2010 09:13:49 -0400 [thread overview]
Message-ID: <20101102131348.GB21476@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <AANLkTikzEdgUqVU0N=y7Vy+fnqKyskVp6p0zMpdYmenk@mail.gmail.com>
On Mon, Nov 01, 2010 at 11:52:04PM -0200, Thiago Farina wrote:
> On Mon, Nov 1, 2010 at 4:20 PM, Mark Brown
> > +enum wm8994_type {
> > + WM8994 = 0,
> > + WM8958 = 1,
> > +};
> Don't need to initialize with = 0 and with = 1. This is done by default.
There is no runtime cost to doing this and so where the values are
important I feel the clarity from documenting the actual values is
useful, it saves anyone having to figure out if they are what is
expected.
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Thiago Farina <tfransosi@gmail.com>
Cc: Samuel Ortiz <sameo@linux.intel.com>,
Liam Girdwood <lrg@slimlogic.co.uk>,
alsa-devel@alsa-project.org, patches@opensource.wolfsonmicro.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mfd: Add initial WM8958 support
Date: Tue, 2 Nov 2010 09:13:49 -0400 [thread overview]
Message-ID: <20101102131348.GB21476@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <AANLkTikzEdgUqVU0N=y7Vy+fnqKyskVp6p0zMpdYmenk@mail.gmail.com>
On Mon, Nov 01, 2010 at 11:52:04PM -0200, Thiago Farina wrote:
> On Mon, Nov 1, 2010 at 4:20 PM, Mark Brown
> > +enum wm8994_type {
> > + WM8994 = 0,
> > + WM8958 = 1,
> > +};
> Don't need to initialize with = 0 and with = 1. This is done by default.
There is no runtime cost to doing this and so where the values are
important I feel the clarity from documenting the actual values is
useful, it saves anyone having to figure out if they are what is
expected.
next prev parent reply other threads:[~2010-11-02 13:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-01 18:20 [PATCH] mfd: Add initial WM8958 support Mark Brown
2010-11-02 1:52 ` Thiago Farina
2010-11-02 13:13 ` Mark Brown [this message]
2010-11-02 13:13 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101102131348.GB21476@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@slimlogic.co.uk \
--cc=patches@opensource.wolfsonmicro.com \
--cc=sameo@linux.intel.com \
--cc=tfransosi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.