* lessen the impact of a deprecated warning in hugetlbfs
@ 2010-11-02 18:06 Dave Jones
2010-11-03 3:04 ` Joe Perches
2010-11-13 1:54 ` Ravikiran G Thirumalai
0 siblings, 2 replies; 3+ messages in thread
From: Dave Jones @ 2010-11-02 18:06 UTC (permalink / raw)
To: Linux Kernel; +Cc: Ravikiran G Thirumalai
WARN_ONCE is a bit strong for a deprecation warning, given that it spews a
huge backtrace.
Signed-off-by: Dave Jones <davej@redhat.com>
--- linux-2.6.36.noarch/fs/hugetlbfs/inode.c~ 2010-11-02 14:01:19.489289082 -0400
+++ linux-2.6.36.noarch/fs/hugetlbfs/inode.c 2010-11-02 14:02:19.947986439 -0400
@@ -915,8 +915,7 @@ struct file *hugetlb_file_setup(const ch
if (creat_flags == HUGETLB_SHMFS_INODE && !can_do_hugetlb_shm()) {
*user = current_user();
if (user_shm_lock(size, *user)) {
- WARN_ONCE(1,
- "Using mlock ulimits for SHM_HUGETLB deprecated\n");
+ printk_once("Using mlock ulimits for SHM_HUGETLB deprecated\n");
} else {
*user = NULL;
return ERR_PTR(-EPERM);
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: lessen the impact of a deprecated warning in hugetlbfs
2010-11-02 18:06 lessen the impact of a deprecated warning in hugetlbfs Dave Jones
@ 2010-11-03 3:04 ` Joe Perches
2010-11-13 1:54 ` Ravikiran G Thirumalai
1 sibling, 0 replies; 3+ messages in thread
From: Joe Perches @ 2010-11-03 3:04 UTC (permalink / raw)
To: Dave Jones; +Cc: Linux Kernel, Ravikiran G Thirumalai
On Tue, 2010-11-02 at 14:06 -0400, Dave Jones wrote:
> WARN_ONCE is a bit strong for a deprecation warning, given that it spews a
> huge backtrace.
>
> Signed-off-by: Dave Jones <davej@redhat.com>
>
> --- linux-2.6.36.noarch/fs/hugetlbfs/inode.c~ 2010-11-02 14:01:19.489289082 -0400
> +++ linux-2.6.36.noarch/fs/hugetlbfs/inode.c 2010-11-02 14:02:19.947986439 -0400
> @@ -915,8 +915,7 @@ struct file *hugetlb_file_setup(const ch
> if (creat_flags == HUGETLB_SHMFS_INODE && !can_do_hugetlb_shm()) {
> *user = current_user();
> if (user_shm_lock(size, *user)) {
> - WARN_ONCE(1,
> - "Using mlock ulimits for SHM_HUGETLB deprecated\n");
> + printk_once("Using mlock ulimits for SHM_HUGETLB deprecated\n");
Please add a KERN_NOTICE or similar.
The grammar could be improved via "is deprecated"
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: lessen the impact of a deprecated warning in hugetlbfs
2010-11-02 18:06 lessen the impact of a deprecated warning in hugetlbfs Dave Jones
2010-11-03 3:04 ` Joe Perches
@ 2010-11-13 1:54 ` Ravikiran G Thirumalai
1 sibling, 0 replies; 3+ messages in thread
From: Ravikiran G Thirumalai @ 2010-11-13 1:54 UTC (permalink / raw)
To: Dave Jones, Linux Kernel
It was to be deprecated by 2.6.31. It is better to kill it I think.
Thanks,
Kiran
On Tue, Nov 02, 2010 at 02:06:22PM -0400, Dave Jones wrote:
>WARN_ONCE is a bit strong for a deprecation warning, given that it spews a
>huge backtrace.
>
>Signed-off-by: Dave Jones <davej@redhat.com>
>
>--- linux-2.6.36.noarch/fs/hugetlbfs/inode.c~ 2010-11-02 14:01:19.489289082 -0400
>+++ linux-2.6.36.noarch/fs/hugetlbfs/inode.c 2010-11-02 14:02:19.947986439 -0400
>@@ -915,8 +915,7 @@ struct file *hugetlb_file_setup(const ch
> if (creat_flags == HUGETLB_SHMFS_INODE && !can_do_hugetlb_shm()) {
> *user = current_user();
> if (user_shm_lock(size, *user)) {
>- WARN_ONCE(1,
>- "Using mlock ulimits for SHM_HUGETLB deprecated\n");
>+ printk_once("Using mlock ulimits for SHM_HUGETLB deprecated\n");
> } else {
> *user = NULL;
> return ERR_PTR(-EPERM);
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-11-13 3:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-11-02 18:06 lessen the impact of a deprecated warning in hugetlbfs Dave Jones
2010-11-03 3:04 ` Joe Perches
2010-11-13 1:54 ` Ravikiran G Thirumalai
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.