From: "Michael S. Tsirkin" <mst@redhat.com>
To: Yang Ruirui <ruirui.r.yang@tieto.com>
Cc: kvm@vger.kernel.org
Subject: Re: [PATCH] building fix - do not check unsigned var >= 0
Date: Tue, 2 Nov 2010 20:58:39 +0200 [thread overview]
Message-ID: <20101102185839.GA2744@redhat.com> (raw)
In-Reply-To: <201010131032.18942.ruirui.r.yang@tieto.com>
On Wed, Oct 13, 2010 at 10:32:18AM +0800, Yang Ruirui wrote:
> fix following build error by do not check unsigned op >= 0:
>
> CC x86_64-softmmu/tcg/tcg.o
> cc1: warnings being treated as errors
> /home/dave/git/qemu-kvm/tcg/tcg.c: In function ‘tcg_add_target_add_op_defs’:
> /home/dave/git/qemu-kvm/tcg/tcg.c:1030: error: comparison of unsigned expression >= 0 is always true
> make[1]: *** [tcg/tcg.o] Error 1
>
> Signed-off-by: Yang Ruirui <ruirui.r.yang@tieto.com>
> Signed-off-by: Dave Young <hidave.darkstar@gmail.com>
I think Blue Swirl was replacing these with range macros from range.h
> ---
> tcg/tcg.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- qemu-kvm.orig/tcg/tcg.c 2010-06-29 14:45:04.000000000 +0800
> +++ qemu-kvm/tcg/tcg.c 2010-09-26 18:07:26.523339798 +0800
> @@ -1027,7 +1027,7 @@ void tcg_add_target_add_op_defs(const TC
> if (tdefs->op == (TCGOpcode)-1)
> break;
> op = tdefs->op;
> - assert(op >= 0 && op < NB_OPS);
> + assert(op < NB_OPS);
> def = &tcg_op_defs[op];
> #if defined(CONFIG_DEBUG_TCG)
> /* Duplicate entry in op definitions? */
> --
> To unsubscribe from this list: send the line "unsubscribe kvm" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2010-11-02 18:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-13 2:32 [PATCH] building fix - do not check unsigned var >= 0 Yang Ruirui
2010-11-02 18:58 ` Michael S. Tsirkin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101102185839.GA2744@redhat.com \
--to=mst@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=ruirui.r.yang@tieto.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.