All of lore.kernel.org
 help / color / mirror / Atom feed
From: Helmut Schaa <helmut.schaa@googlemail.com>
To: ath9k-devel@lists.ath9k.org
Subject: [ath9k-devel] [RFC] ath9k: fix tx queue selection
Date: Tue, 2 Nov 2010 23:59:11 +0100	[thread overview]
Message-ID: <201011022359.12025.helmut.schaa@googlemail.com> (raw)
In-Reply-To: <4CD046D2.4080703@openwrt.org>

Am Dienstag 02 November 2010 schrieb Felix Fietkau:
> On 2010-11-02 5:13 PM, Bj?rn Smedman wrote:
> > The following patch attempts to fix some problems with ath9k tx queue 
> > selection:
> > 
> > 1. There was a posible mismatch between the queue selected for QoS packets 
> > (on which locking, queue start/stop and statistics where performed) and 
> > the queue actually used for TX. This is fixed by selecting the tx queue 
> > based on the TID of the 802.11 header for this type of packet.
> This should not be necessary. mac80211 should take care of queue
> selection properly for QoS frames. If it doesn't, then that is the bug
> that needs to be fixed...

Not sure if this is related but I had some issues with rt2800pci and tx queue
selection as well. This was caused by a bug in the net stack. See [1] for the
details.

I don't have any clue if this also affects ath9k but this issue sounds similar.

Helmut

[1] http://www.spinics.net/lists/netdev/msg139832.html

WARNING: multiple messages have this Message-ID (diff)
From: Helmut Schaa <helmut.schaa@googlemail.com>
To: "Björn Smedman" <bjorn.smedman@venatech.se>
Cc: Felix Fietkau <nbd@openwrt.org>,
	ath9k-devel@lists.ath9k.org,
	"linux-wireless" <linux-wireless@vger.kernel.org>
Subject: Re: [ath9k-devel] [RFC] ath9k: fix tx queue selection
Date: Tue, 2 Nov 2010 23:59:11 +0100	[thread overview]
Message-ID: <201011022359.12025.helmut.schaa@googlemail.com> (raw)
In-Reply-To: <4CD046D2.4080703@openwrt.org>

Am Dienstag 02 November 2010 schrieb Felix Fietkau:
> On 2010-11-02 5:13 PM, Björn Smedman wrote:
> > The following patch attempts to fix some problems with ath9k tx queue 
> > selection:
> > 
> > 1. There was a posible mismatch between the queue selected for QoS packets 
> > (on which locking, queue start/stop and statistics where performed) and 
> > the queue actually used for TX. This is fixed by selecting the tx queue 
> > based on the TID of the 802.11 header for this type of packet.
> This should not be necessary. mac80211 should take care of queue
> selection properly for QoS frames. If it doesn't, then that is the bug
> that needs to be fixed...

Not sure if this is related but I had some issues with rt2800pci and tx queue
selection as well. This was caused by a bug in the net stack. See [1] for the
details.

I don't have any clue if this also affects ath9k but this issue sounds similar.

Helmut

[1] http://www.spinics.net/lists/netdev/msg139832.html

  parent reply	other threads:[~2010-11-02 22:59 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-02 16:13 [ath9k-devel] [RFC] ath9k: fix tx queue selection Björn Smedman
2010-11-02 17:13 ` Felix Fietkau
2010-11-02 17:13   ` Felix Fietkau
2010-11-02 17:37   ` Felix Fietkau
2010-11-02 17:37     ` Felix Fietkau
2010-11-02 18:20     ` Björn Smedman
2010-11-02 18:20       ` Björn Smedman
2010-11-02 18:54       ` Felix Fietkau
2010-11-02 18:54         ` Felix Fietkau
2010-11-02 19:16         ` Björn Smedman
2010-11-02 19:16           ` Björn Smedman
2010-11-02 22:11           ` Felix Fietkau
2010-11-02 22:11             ` Felix Fietkau
2010-11-03 11:35             ` Björn Smedman
2010-11-03 11:35               ` Björn Smedman
2010-11-03 11:53               ` Felix Fietkau
2010-11-03 11:53                 ` Felix Fietkau
2010-11-03 16:27                 ` Björn Smedman
2010-11-03 16:27                   ` Björn Smedman
2010-11-03 16:56                   ` Felix Fietkau
2010-11-03 16:56                     ` Felix Fietkau
2010-11-03 17:04                     ` Ben Greear
2010-11-03 17:04                       ` Ben Greear
2010-11-03 17:31                     ` Björn Smedman
2010-11-03 17:31                       ` Björn Smedman
2010-11-03 17:48                       ` Felix Fietkau
2010-11-03 17:48                         ` Felix Fietkau
2010-11-02 18:12   ` Björn Smedman
2010-11-02 18:12     ` Björn Smedman
2010-11-02 22:59   ` Helmut Schaa [this message]
2010-11-02 22:59     ` Helmut Schaa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201011022359.12025.helmut.schaa@googlemail.com \
    --to=helmut.schaa@googlemail.com \
    --cc=ath9k-devel@lists.ath9k.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.