From: Andi Kleen <andi@firstfloor.org>
To: Tejun Heo <tj@kernel.org>
Cc: Christophe Saout <christophe@saout.de>,
Mike Snitzer <snitzer@redhat.com>,
Brian Swetland <swetland@google.com>, San Mehat <san@google.com>,
device-mapper development <dm-devel@redhat.com>,
andi@firstfloor.org, Andrew Morton <akpm@linux-foundation.org>,
Alasdair G Kergon <agk@redhat.com>, Milan Broz <mbroz@redhat.com>
Subject: Re: cmwq and dm-crypt devices?
Date: Wed, 3 Nov 2010 12:51:44 +0100 [thread overview]
Message-ID: <20101103115144.GA18935@basil.fritz.box> (raw)
In-Reply-To: <4CD12F6E.8040501@kernel.org>
>
> > 2) scale up the number of workqueue threads used for a single dm-crypt
> > device so that a device can realize per-cpu concurrency (to address
> > Andi's scalability concerns: https://patchwork.kernel.org/patch/244031/)
They are already addressed in my patchkit and the patches seem to be used
by more and more users. It's just you guys who are behind.
> >
> > [the desired locality is currently missing due to dm-crypt's current
> > use of WQ_UNBOUND; so it is clear the way the workqueues are created
> > will be important]
>
> I don't know enough about dm-crypt workload to tell whether per-cpu
> affinity would be better or not, but it's really a simple matter of
CPU affinity and an own thread makes sense for the crypto helper
because it uses up a lot of CPU time.
For the IO helper you probably still want CPU affinity, but it
can be concurrency managed.
-andi
next prev parent reply other threads:[~2010-11-03 11:51 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-22 17:48 [PATCH] md: dm-crypt: Add option to re-use a new global work-queue San Mehat
2010-04-22 18:03 ` Milan Broz
2010-04-22 18:08 ` San Mehat
2010-04-22 18:47 ` Milan Broz
2010-04-22 19:42 ` San Mehat
2010-04-23 14:01 ` Heinz Mauelshagen
2010-04-27 20:58 ` San Mehat
2010-11-02 22:02 ` cmwq and dm-crypt devices? (was: Re: md: dm-crypt: Add option to re-use a new global work-queue.) Mike Snitzer
2010-11-03 9:46 ` cmwq and dm-crypt devices? Tejun Heo
2010-11-03 11:51 ` Andi Kleen [this message]
2010-11-03 11:56 ` Milan Broz
2010-11-03 12:33 ` Andi Kleen
2010-11-03 13:02 ` Milan Broz
2010-11-03 13:18 ` Alasdair G Kergon
2010-11-03 16:13 ` Andi Kleen
2010-11-03 16:17 ` Tejun Heo
2010-11-03 16:22 ` Milan Broz
2010-11-04 9:55 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101103115144.GA18935@basil.fritz.box \
--to=andi@firstfloor.org \
--cc=agk@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=christophe@saout.de \
--cc=dm-devel@redhat.com \
--cc=mbroz@redhat.com \
--cc=san@google.com \
--cc=snitzer@redhat.com \
--cc=swetland@google.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.