From: Andi Kleen <andi@firstfloor.org>
To: Andi Kleen <andi@firstfloor.org>, Milan Broz <mbroz@redhat.com>,
Christophe Saout <christophe@saout.de>,
Mike Snitzer <snitzer@redhat.com>, Brian Swetland <swetla>
Subject: Re: cmwq and dm-crypt devices?
Date: Wed, 3 Nov 2010 17:13:27 +0100 [thread overview]
Message-ID: <20101103161327.GC18935@basil.fritz.box> (raw)
In-Reply-To: <20101103131835.GB5833@agk-dp.fab.redhat.com>
> Please fix this regression the patch causes then or give some
> fundamental arguments why we can't satisfy the two requirements
> simultaneously: I just don't understand why it is necessary to cause a
> regression in stacking/low memory support in order to provide the
> performance boost in the way you desire. The two things ought to be
> independent of each other.
The old stacking relies on per device threads. Per device threads
cannot be combined with per CPU threads, because that would lead
to a thread explosion for large device counts.
I thought I had handled stacking, but my implementation doesn't
seem to fully work. Most likely it needs a fallback thread
or using one of the available workqueues.
> (And I remain sceptical about the suitability of the patch even with a
> stack of just two or three layers as I don't see anything in the failed
> tests that shows why similar failures couldn't in principle affect
Yes most likely the problem happens with any stacking > 0.
-Andi
--
ak@linux.intel.com -- Speaking for myself only.
next prev parent reply other threads:[~2010-11-03 16:13 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-22 17:48 [PATCH] md: dm-crypt: Add option to re-use a new global work-queue San Mehat
2010-04-22 18:03 ` Milan Broz
2010-04-22 18:08 ` San Mehat
2010-04-22 18:47 ` Milan Broz
2010-04-22 19:42 ` San Mehat
2010-04-23 14:01 ` Heinz Mauelshagen
2010-04-27 20:58 ` San Mehat
2010-11-02 22:02 ` cmwq and dm-crypt devices? (was: Re: md: dm-crypt: Add option to re-use a new global work-queue.) Mike Snitzer
2010-11-03 9:46 ` cmwq and dm-crypt devices? Tejun Heo
2010-11-03 11:51 ` Andi Kleen
2010-11-03 11:56 ` Milan Broz
2010-11-03 12:33 ` Andi Kleen
2010-11-03 13:02 ` Milan Broz
2010-11-03 13:18 ` Alasdair G Kergon
2010-11-03 16:13 ` Andi Kleen [this message]
2010-11-03 16:17 ` Tejun Heo
2010-11-03 16:22 ` Milan Broz
2010-11-04 9:55 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101103161327.GC18935@basil.fritz.box \
--to=andi@firstfloor.org \
--cc=christophe@saout.de \
--cc=dm-devel@redhat.com \
--cc=mbroz@redhat.com \
--cc=snitzer@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.