All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wu Fengguang <fengguang.wu@intel.com>
To: Jesper Juhl <jj@chaosbits.net>
Cc: Johannes Weiner <hannes@cmpxchg.org>,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	Balbir Singh <balbir@linux.vnet.ibm.com>,
	Pavel Emelianov <xemul@openvz.org>,
	Minchan Kim <minchan.kim@gmail.com>,
	Paul Menage <menage@google.com>, Li Zefan <lizf@cn.fujitsu.com>,
	containers@lists.linux-foundation.org
Subject: Re: [PATCH] cgroup: prefer [kv]zalloc over [kv]malloc+memset in memory controller code.
Date: Wed, 3 Nov 2010 22:15:29 +0800	[thread overview]
Message-ID: <20101103141529.GA7713@localhost> (raw)
In-Reply-To: <alpine.LNX.2.00.1011012056250.12889@swampdragon.chaosbits.net>

On Mon, Nov 01, 2010 at 08:59:13PM +0100, Jesper Juhl wrote:

> @@ -4169,13 +4169,11 @@ static int alloc_mem_cgroup_per_zone_info(struct mem_cgroup *mem, int node)
>  	 */
>  	if (!node_state(node, N_NORMAL_MEMORY))
>  		tmp = -1;
> -	pn = kmalloc_node(sizeof(*pn), GFP_KERNEL, tmp);
> +	pn = kmalloc_node(sizeof(*pn), GFP_KERNEL|__GFP_ZERO, tmp);

Use the simpler kzalloc_node()? It's introduced here:

        commit 979b0fea2d9ae5d57237a368d571cbc84655fba6
        Author: Jeff Layton <jlayton@redhat.com>
        Date:   Thu Jun 5 22:47:00 2008 -0700

            vm: add kzalloc_node() inline


Reviewed-by: Wu Fengguang <fengguang.wu@intel.com>

Thanks,
Fengguang

WARNING: multiple messages have this Message-ID (diff)
From: Wu Fengguang <fengguang.wu@intel.com>
To: Jesper Juhl <jj@chaosbits.net>
Cc: Johannes Weiner <hannes@cmpxchg.org>,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	Balbir Singh <balbir@linux.vnet.ibm.com>,
	Pavel Emelianov <xemul@openvz.org>,
	Minchan Kim <minchan.kim@gmail.com>,
	Paul Menage <menage@google.com>, Li Zefan <lizf@cn.fujitsu.com>,
	containers@lists.linux-foundation.org
Subject: Re: [PATCH] cgroup: prefer [kv]zalloc over [kv]malloc+memset in memory controller code.
Date: Wed, 3 Nov 2010 22:15:29 +0800	[thread overview]
Message-ID: <20101103141529.GA7713@localhost> (raw)
In-Reply-To: <alpine.LNX.2.00.1011012056250.12889@swampdragon.chaosbits.net>

On Mon, Nov 01, 2010 at 08:59:13PM +0100, Jesper Juhl wrote:

> @@ -4169,13 +4169,11 @@ static int alloc_mem_cgroup_per_zone_info(struct mem_cgroup *mem, int node)
>  	 */
>  	if (!node_state(node, N_NORMAL_MEMORY))
>  		tmp = -1;
> -	pn = kmalloc_node(sizeof(*pn), GFP_KERNEL, tmp);
> +	pn = kmalloc_node(sizeof(*pn), GFP_KERNEL|__GFP_ZERO, tmp);

Use the simpler kzalloc_node()? It's introduced here:

        commit 979b0fea2d9ae5d57237a368d571cbc84655fba6
        Author: Jeff Layton <jlayton@redhat.com>
        Date:   Thu Jun 5 22:47:00 2008 -0700

            vm: add kzalloc_node() inline


Reviewed-by: Wu Fengguang <fengguang.wu@intel.com>

Thanks,
Fengguang

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom policy in Canada: sign http://dissolvethecrtc.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  parent reply	other threads:[~2010-11-03 14:15 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-01 19:40 [PATCH] cgroup: prefer [kv]zalloc over [kv]malloc+memset in memory controller code Jesper Juhl
2010-11-01 19:40 ` Jesper Juhl
2010-11-01 19:58 ` Hiroyuki Kamezawa
2010-11-01 19:58   ` Hiroyuki Kamezawa
2010-11-01 20:01 ` Johannes Weiner
2010-11-01 20:01   ` Johannes Weiner
2010-11-01 19:59   ` Jesper Juhl
2010-11-01 19:59     ` Jesper Juhl
2010-11-01 23:21     ` Minchan Kim
2010-11-01 23:21       ` Minchan Kim
     [not found]     ` <alpine.LNX.2.00.1011012056250.12889-h2p7t3/P30RzeRGmFJ5qR7ZzlVVXadcDXqFh9Ls21Oc@public.gmane.org>
2010-11-01 23:21       ` Minchan Kim
2010-11-02 12:24       ` Johannes Weiner
2010-11-03 14:15       ` Wu Fengguang
2010-11-02 12:24     ` Johannes Weiner
2010-11-02 12:24       ` Johannes Weiner
2010-11-03 14:15     ` Wu Fengguang [this message]
2010-11-03 14:15       ` Wu Fengguang
     [not found]   ` <20101101200122.GH840-druUgvl0LCNAfugRpC6u6w@public.gmane.org>
2010-11-01 19:59     ` Jesper Juhl
2010-11-02  5:07 ` Balbir Singh
2010-11-02  5:07   ` Balbir Singh
     [not found] ` <alpine.LNX.2.00.1011012038490.12889-h2p7t3/P30RzeRGmFJ5qR7ZzlVVXadcDXqFh9Ls21Oc@public.gmane.org>
2010-11-01 19:58   ` Hiroyuki Kamezawa
2010-11-01 20:01   ` Johannes Weiner
2010-11-02  5:07   ` Balbir Singh
  -- strict thread matches above, loose matches on Subject: below --
2010-11-01 19:40 Jesper Juhl
2010-11-01 19:35 Jesper Juhl
2010-11-01 23:11 ` Minchan Kim
     [not found] ` <alpine.LNX.2.00.1011012030150.12889-h2p7t3/P30RzeRGmFJ5qR7ZzlVVXadcDXqFh9Ls21Oc@public.gmane.org>
2010-11-01 23:11   ` Minchan Kim
2010-11-01 19:35 Jesper Juhl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101103141529.GA7713@localhost \
    --to=fengguang.wu@intel.com \
    --cc=balbir@linux.vnet.ibm.com \
    --cc=containers@lists.linux-foundation.org \
    --cc=hannes@cmpxchg.org \
    --cc=jj@chaosbits.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=lizf@cn.fujitsu.com \
    --cc=menage@google.com \
    --cc=minchan.kim@gmail.com \
    --cc=xemul@openvz.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.