From: Dan Carpenter <error27@gmail.com>
To: Jeff Layton <jlayton-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: Steve French <sfrench-eUNUBHrolfbYtjvyW6yDsg@public.gmane.org>,
linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
samba-technical-w/Ol4Ecudpl8XjKLYN78aQ@public.gmane.org,
kernel-janitors-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [patch 2/2] cifs: dereferencing first then checking
Date: Wed, 03 Nov 2010 16:40:59 +0000 [thread overview]
Message-ID: <20101103164059.GH14069@bicker> (raw)
In-Reply-To: <20101102162250.3a2aa670-9yPaYZwiELC+kQycOl6kW4xkIHaj4LzF@public.gmane.org>
On Tue, Nov 02, 2010 at 04:22:50PM -0400, Jeff Layton wrote:
> Here's a respun patch that should fix these problems. I chickened out
> on removing the check in find_writable_file.
>
> It still seems like a bogus cargo-cult sort of thing. It should
> probably be a BUG() if you call that function with a NULL pointer, but
> I don't feel like tackling that just yet.
>
> Dan, does this look ok to you? If so, I'll resend to Steve as an
> "official" patch.
>
Looks fine to me. Obviously, I've already said that I don't know if the
checks are needed or not. I defer to your greater knowledge. ;)
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <error27-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Jeff Layton <jlayton-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: Steve French <sfrench-eUNUBHrolfbYtjvyW6yDsg@public.gmane.org>,
linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
samba-technical-w/Ol4Ecudpl8XjKLYN78aQ@public.gmane.org,
kernel-janitors-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [patch 2/2] cifs: dereferencing first then checking
Date: Wed, 3 Nov 2010 18:40:59 +0200 [thread overview]
Message-ID: <20101103164059.GH14069@bicker> (raw)
In-Reply-To: <20101102162250.3a2aa670-9yPaYZwiELC+kQycOl6kW4xkIHaj4LzF@public.gmane.org>
On Tue, Nov 02, 2010 at 04:22:50PM -0400, Jeff Layton wrote:
> Here's a respun patch that should fix these problems. I chickened out
> on removing the check in find_writable_file.
>
> It still seems like a bogus cargo-cult sort of thing. It should
> probably be a BUG() if you call that function with a NULL pointer, but
> I don't feel like tackling that just yet.
>
> Dan, does this look ok to you? If so, I'll resend to Steve as an
> "official" patch.
>
Looks fine to me. Obviously, I've already said that I don't know if the
checks are needed or not. I defer to your greater knowledge. ;)
regards,
dan carpenter
next prev parent reply other threads:[~2010-11-03 16:40 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-27 21:22 [patch 2/2] cifs: dereferencing first then checking Dan Carpenter
2010-10-27 21:22 ` Dan Carpenter
2010-10-27 23:51 ` Jeff Layton
2010-10-27 23:51 ` Jeff Layton
[not found] ` <20101027195123.0a712a53-9yPaYZwiELC+kQycOl6kW4xkIHaj4LzF@public.gmane.org>
2010-10-28 3:44 ` Dan Carpenter
2010-10-28 3:44 ` Dan Carpenter
2010-11-02 20:22 ` Jeff Layton
2010-11-02 20:22 ` Jeff Layton
[not found] ` <20101102162250.3a2aa670-9yPaYZwiELC+kQycOl6kW4xkIHaj4LzF@public.gmane.org>
2010-11-03 16:40 ` Dan Carpenter [this message]
2010-11-03 16:40 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101103164059.GH14069@bicker \
--to=error27@gmail.com \
--cc=jlayton-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=kernel-janitors-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=samba-technical-w/Ol4Ecudpl8XjKLYN78aQ@public.gmane.org \
--cc=sfrench-eUNUBHrolfbYtjvyW6yDsg@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.