From: Mike Snitzer <snitzer@redhat.com>
To: device-mapper development <dm-devel@redhat.com>
Cc: jack@suse.cz, leochen@broadcom.com, heiko.carstens@de.ibm.com,
adilger.kernel@dilger.ca, konishi.ryusuke@lab.ntt.co.jp,
shaggy@linux.vnet.ibm.com, drbd-dev@lists.linbit.com,
joel.becker@oracle.com, hch@infradead.org, aelder@sgi.com,
mfasheh@suse.com, joern@logfs.org,
reiserfs-devel@vger.kernel.org, schwidefsky@de.ibm.com,
viro@zeniv.linux.org.uk, swhiteho@redhat.com,
chris.mason@oracle.com, axboe@kernel.dk, tytso@mit.edu,
sbranden@broadcom.com, petero2@telia.com,
linux-kernel@vger.kernel.org, Tejun Heo <tj@kernel.org>,
akpm@linux-foundation.org
Subject: Re: [PATCH 4/5] block: make blkdev_get/put() handle exclusive access
Date: Thu, 4 Nov 2010 11:04:00 -0400 [thread overview]
Message-ID: <20101104150400.GA32504@redhat.com> (raw)
In-Reply-To: <20101103161059.GA13621@infradead.org>
On Wed, Nov 03 2010 at 12:10pm -0400,
Christoph Hellwig <hch@infradead.org> wrote:
> On Mon, Nov 01, 2010 at 05:15:28PM +0100, Tejun Heo wrote:
> > * blkdev_get() is extended to include exclusive access management.
> > @holder argument is added and, if is @FMODE_EXCL specified, it will
> > gain exclusive access atomically w.r.t. other exclusive accesses.
> >
> > * blkdev_put() is similarly extended. It now takes @mode argument and
> > if @FMODE_EXCL is set, it releases an exclusive access. Also, when
> > the last exclusive claim is released, the holder/slave symlinks are
> > removed automatically.
>
> Could we get rid of FMODE_EXCL and just make a non-NULL holder field
> mean to open it exlusively (and pass a holder to the blkdev_put to
> release it)?
I agree that the need for a FMODE_EXCL flag is awkward. Christoph's
proposed change should clean things up nicely.
Other than that, for the DM bits:
Acked-by: Mike Snitzer <snitzer@redhat.com>
WARNING: multiple messages have this Message-ID (diff)
From: Mike Snitzer <snitzer@redhat.com>
To: device-mapper development <dm-devel@redhat.com>
Cc: jack@suse.cz, leochen@broadcom.com, heiko.carstens@de.ibm.com,
adilger.kernel@dilger.ca, konishi.ryusuke@lab.ntt.co.jp,
shaggy@linux.vnet.ibm.com, drbd-dev@lists.linbit.com,
joel.becker@oracle.com, hch@infradead.org, aelder@sgi.com,
mfasheh@suse.com, joern@logfs.org,
reiserfs-devel@vger.kernel.org, schwidefsky@de.ibm.com,
viro@zeniv.linux.org.uk, swhiteho@redhat.com,
chris.mason@oracle.com, axboe@kernel.dk, tytso@mit.edu,
sbranden@broadcom.com, petero2@telia.com,
linux-kernel@vger.kernel.org, Tejun Heo <tj@kernel.org>,
akpm@linux-foundation.org
Subject: Re: [Drbd-dev] [PATCH 4/5] block: make blkdev_get/put() handle exclusive access
Date: Thu, 4 Nov 2010 11:04:00 -0400 [thread overview]
Message-ID: <20101104150400.GA32504@redhat.com> (raw)
In-Reply-To: <20101103161059.GA13621@infradead.org>
On Wed, Nov 03 2010 at 12:10pm -0400,
Christoph Hellwig <hch@infradead.org> wrote:
> On Mon, Nov 01, 2010 at 05:15:28PM +0100, Tejun Heo wrote:
> > * blkdev_get() is extended to include exclusive access management.
> > @holder argument is added and, if is @FMODE_EXCL specified, it will
> > gain exclusive access atomically w.r.t. other exclusive accesses.
> >
> > * blkdev_put() is similarly extended. It now takes @mode argument and
> > if @FMODE_EXCL is set, it releases an exclusive access. Also, when
> > the last exclusive claim is released, the holder/slave symlinks are
> > removed automatically.
>
> Could we get rid of FMODE_EXCL and just make a non-NULL holder field
> mean to open it exlusively (and pass a holder to the blkdev_put to
> release it)?
I agree that the need for a FMODE_EXCL flag is awkward. Christoph's
proposed change should clean things up nicely.
Other than that, for the DM bits:
Acked-by: Mike Snitzer <snitzer@redhat.com>
WARNING: multiple messages have this Message-ID (diff)
From: Mike Snitzer <snitzer@redhat.com>
To: device-mapper development <dm-devel@redhat.com>
Cc: Tejun Heo <tj@kernel.org>,
jack@suse.cz, leochen@broadcom.com, heiko.carstens@de.ibm.com,
adilger.kernel@dilger.ca, konishi.ryusuke@lab.ntt.co.jp,
shaggy@linux.vnet.ibm.com, drbd-dev@lists.linbit.com,
joel.becker@oracle.com, hch@infradead.org, aelder@sgi.com,
mfasheh@suse.com, joern@logfs.org,
reiserfs-devel@vger.kernel.org, viro@zeniv.linux.org.uk,
swhiteho@redhat.com, chris.mason@oracle.com, axboe@kernel.dk,
tytso@mit.edu, sbranden@broadcom.com, petero2@telia.com,
linux-kernel@vger.kernel.org, schwidefsky@de.ibm.com,
akpm@linux-foundation.org
Subject: Re: [PATCH 4/5] block: make blkdev_get/put() handle exclusive access
Date: Thu, 4 Nov 2010 11:04:00 -0400 [thread overview]
Message-ID: <20101104150400.GA32504@redhat.com> (raw)
In-Reply-To: <20101103161059.GA13621@infradead.org>
On Wed, Nov 03 2010 at 12:10pm -0400,
Christoph Hellwig <hch@infradead.org> wrote:
> On Mon, Nov 01, 2010 at 05:15:28PM +0100, Tejun Heo wrote:
> > * blkdev_get() is extended to include exclusive access management.
> > @holder argument is added and, if is @FMODE_EXCL specified, it will
> > gain exclusive access atomically w.r.t. other exclusive accesses.
> >
> > * blkdev_put() is similarly extended. It now takes @mode argument and
> > if @FMODE_EXCL is set, it releases an exclusive access. Also, when
> > the last exclusive claim is released, the holder/slave symlinks are
> > removed automatically.
>
> Could we get rid of FMODE_EXCL and just make a non-NULL holder field
> mean to open it exlusively (and pass a holder to the blkdev_put to
> release it)?
I agree that the need for a FMODE_EXCL flag is awkward. Christoph's
proposed change should clean things up nicely.
Other than that, for the DM bits:
Acked-by: Mike Snitzer <snitzer@redhat.com>
next prev parent reply other threads:[~2010-11-04 15:04 UTC|newest]
Thread overview: 80+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-01 16:15 [PATCHSET] block: clean up bdev claim/release handling Tejun Heo
2010-11-01 16:15 ` Tejun Heo
2010-11-01 16:15 ` [Drbd-dev] " Tejun Heo
2010-11-01 16:15 ` [PATCH 1/5] mtd: fix bdev exclusive open bugs in block2mtd::add_device() Tejun Heo
2010-11-01 16:15 ` Tejun Heo
2010-11-01 16:15 ` Tejun Heo
2010-11-01 16:15 ` [Drbd-dev] " Tejun Heo
2010-11-13 10:38 ` Artem Bityutskiy
2010-11-13 10:38 ` Artem Bityutskiy
2010-11-13 10:38 ` Artem Bityutskiy
2010-11-13 10:42 ` Tejun Heo
2010-11-13 10:42 ` [Drbd-dev] " Tejun Heo
2010-11-13 10:42 ` Tejun Heo
2010-11-13 11:10 ` Artem Bityutskiy
2010-11-13 11:10 ` Artem Bityutskiy
2010-11-13 11:10 ` Artem Bityutskiy
2010-11-13 10:59 ` [PATCH UPDATED " Tejun Heo
2010-11-13 10:59 ` [Drbd-dev] " Tejun Heo
2010-11-13 10:59 ` Tejun Heo
2010-11-13 11:14 ` Artem Bityutskiy
2010-11-13 11:14 ` Artem Bityutskiy
2010-11-13 11:14 ` Artem Bityutskiy
2010-11-13 11:18 ` Tejun Heo
2010-11-13 11:18 ` [Drbd-dev] " Tejun Heo
2010-11-13 11:18 ` Tejun Heo
2010-11-01 16:15 ` [Drbd-dev] [PATCH 2/5] btrfs: close_bdev_exclusive() should use the same @flags as the matching open_bdev_exclusive() Tejun Heo
2010-11-01 16:15 ` Tejun Heo
2010-11-01 16:15 ` Tejun Heo
2010-11-01 16:15 ` Tejun Heo
2010-11-01 16:15 ` [PATCH 3/5] block: simplify holder symlink handling Tejun Heo
2010-11-01 16:15 ` [Drbd-dev] " Tejun Heo
2010-11-01 16:15 ` Tejun Heo
2010-11-04 15:06 ` Mike Snitzer
2010-11-04 15:06 ` Mike Snitzer
2010-11-04 15:06 ` [Drbd-dev] " Mike Snitzer
2010-11-01 16:15 ` Tejun Heo
2010-11-01 16:15 ` [PATCH 4/5] block: make blkdev_get/put() handle exclusive access Tejun Heo
2010-11-01 16:15 ` Tejun Heo
2010-11-01 16:15 ` [Drbd-dev] " Tejun Heo
2010-11-03 15:06 ` Jan Kara
2010-11-03 15:06 ` [Drbd-dev] " Jan Kara
2010-11-09 10:18 ` Tejun Heo
2010-11-09 10:18 ` [Drbd-dev] " Tejun Heo
2010-11-03 16:10 ` Christoph Hellwig
2010-11-03 16:10 ` [Drbd-dev] " Christoph Hellwig
2010-11-04 15:04 ` Mike Snitzer [this message]
2010-11-04 15:04 ` Mike Snitzer
2010-11-04 15:04 ` [Drbd-dev] " Mike Snitzer
2010-11-09 10:34 ` Tejun Heo
2010-11-09 10:34 ` [Drbd-dev] " Tejun Heo
2010-11-09 10:36 ` Christoph Hellwig
2010-11-09 10:36 ` [Drbd-dev] " Christoph Hellwig
2010-11-01 16:15 ` Tejun Heo
2010-11-01 16:15 ` [PATCH 5/5] block: reorganize claim/release implementation Tejun Heo
2010-11-01 16:15 ` [Drbd-dev] " Tejun Heo
2010-11-01 16:15 ` Tejun Heo
2010-11-01 16:15 ` Tejun Heo
2010-11-01 19:49 ` [PATCHSET] block: clean up bdev claim/release handling Neil Brown
2010-11-01 19:49 ` [Drbd-dev] " Neil Brown
2010-11-03 15:53 ` Philipp Reisner
2010-11-03 15:53 ` Philipp Reisner
2010-11-11 17:10 ` [PATCH 6/5] block: check bdev_read_only() from blkdev_get() Tejun Heo
2010-11-11 17:10 ` Tejun Heo
2010-11-11 17:10 ` [Drbd-dev] " Tejun Heo
2010-11-11 17:10 ` Tejun Heo
2010-11-11 17:11 ` [PATCH 7/5] block: clean up blkdev_get() wrappers and their users Tejun Heo
2010-11-11 17:11 ` Tejun Heo
2010-11-11 17:11 ` [Drbd-dev] " Tejun Heo
2010-11-11 19:19 ` Steven Whitehouse
2010-11-11 17:11 ` Tejun Heo
2010-11-11 17:14 ` [PATCHSET] block: clean up bdev claim/release handling Tejun Heo
2010-11-11 17:14 ` Tejun Heo
2010-11-11 17:14 ` [Drbd-dev] " Tejun Heo
2010-11-27 16:01 ` Tejun Heo
2010-11-27 16:01 ` Tejun Heo
2010-11-27 16:01 ` Tejun Heo
2010-11-27 16:01 ` [Drbd-dev] " Tejun Heo
2010-11-27 18:47 ` Jens Axboe
2010-11-27 18:47 ` [Drbd-dev] " Jens Axboe
2010-11-11 17:14 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101104150400.GA32504@redhat.com \
--to=snitzer@redhat.com \
--cc=adilger.kernel@dilger.ca \
--cc=aelder@sgi.com \
--cc=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=chris.mason@oracle.com \
--cc=dm-devel@redhat.com \
--cc=drbd-dev@lists.linbit.com \
--cc=hch@infradead.org \
--cc=heiko.carstens@de.ibm.com \
--cc=jack@suse.cz \
--cc=joel.becker@oracle.com \
--cc=joern@logfs.org \
--cc=konishi.ryusuke@lab.ntt.co.jp \
--cc=leochen@broadcom.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mfasheh@suse.com \
--cc=petero2@telia.com \
--cc=reiserfs-devel@vger.kernel.org \
--cc=sbranden@broadcom.com \
--cc=schwidefsky@de.ibm.com \
--cc=shaggy@linux.vnet.ibm.com \
--cc=swhiteho@redhat.com \
--cc=tj@kernel.org \
--cc=tytso@mit.edu \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.