From: Martin Pitt <martin.pitt@ubuntu.com>
To: Bastien Nocera <hadess@hadess.net>
Cc: linux-input <linux-input@vger.kernel.org>,
linux-hotplug@vger.kernel.org, xorg@lists.freedesktop.org,
Peter Hutterer <peter.hutterer@who-t.net>,
Matthew Garrett <mjg59@srcf.ucam.org>
Subject: Re: Touchpad toggle mess
Date: Sat, 06 Nov 2010 15:30:31 +0000 [thread overview]
Message-ID: <20101106153031.GA2215@piware.de> (raw)
In-Reply-To: <1288915209.5418.72.camel@novo.hadess.net>
[-- Attachment #1: Type: text/plain, Size: 1539 bytes --]
Hello Bastien,
Bastien Nocera [2010-11-05 0:00 +0000]:
> The patches in https://bugs.freedesktop.org/show_bug.cgi?id=31300
> implement this for the kernel, and for X.org.
>
> Then we have the problem that udev's keymaps seem to use different
> function keys depending on the hardware [1], when X.org (because of the
> limitations of XKB) standardised on F22 for "XF86TouchpadToggle".
Thanks for bringing this up, indeed there's some cleanup in order
here.
> So we'll need to standardise on the keys used. I selected F21 for
> XF86TouchpadToggle, F22 for XF86TouchpadOn and F23 for XF86TouchpadOff.
> See the patch in:
> https://bugs.freedesktop.org/show_bug.cgi?id=31333
>
> The remaining fixes would need to be in udev's keymaps, to set hardware
> handled keys to F22 and F23, and software ones to F21. Patch is attached
> for that.
Indeed the maps which don't currently use f22 should be fixed,
regardless of what happens in X/kernel/userspace. My main concern is
that F22 has acted as touchpad toggle key for years (many of those
were imported from hal-info originally), so if we change everything to
f21 now without updating userspace (things like gnome-settings-daemon)
in lockstep, then we break existing functionality.
It would look slightly weird, but perhaps it might be better to keep
using F22 for toggling, and F1->on, F23->off?
Thanks,
Martin
--
Martin Pitt | http://www.piware.de
Ubuntu Developer (www.ubuntu.com) | Debian Developer (www.debian.org)
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Martin Pitt <martin.pitt@ubuntu.com>
To: Bastien Nocera <hadess@hadess.net>
Cc: linux-input <linux-input@vger.kernel.org>,
linux-hotplug@vger.kernel.org, xorg@lists.freedesktop.org,
Peter Hutterer <peter.hutterer@who-t.net>,
Matthew Garrett <mjg59@srcf.ucam.org>
Subject: Re: Touchpad toggle mess
Date: Sat, 6 Nov 2010 11:30:31 -0400 [thread overview]
Message-ID: <20101106153031.GA2215@piware.de> (raw)
In-Reply-To: <1288915209.5418.72.camel@novo.hadess.net>
[-- Attachment #1: Type: text/plain, Size: 1539 bytes --]
Hello Bastien,
Bastien Nocera [2010-11-05 0:00 +0000]:
> The patches in https://bugs.freedesktop.org/show_bug.cgi?id=31300
> implement this for the kernel, and for X.org.
>
> Then we have the problem that udev's keymaps seem to use different
> function keys depending on the hardware [1], when X.org (because of the
> limitations of XKB) standardised on F22 for "XF86TouchpadToggle".
Thanks for bringing this up, indeed there's some cleanup in order
here.
> So we'll need to standardise on the keys used. I selected F21 for
> XF86TouchpadToggle, F22 for XF86TouchpadOn and F23 for XF86TouchpadOff.
> See the patch in:
> https://bugs.freedesktop.org/show_bug.cgi?id=31333
>
> The remaining fixes would need to be in udev's keymaps, to set hardware
> handled keys to F22 and F23, and software ones to F21. Patch is attached
> for that.
Indeed the maps which don't currently use f22 should be fixed,
regardless of what happens in X/kernel/userspace. My main concern is
that F22 has acted as touchpad toggle key for years (many of those
were imported from hal-info originally), so if we change everything to
f21 now without updating userspace (things like gnome-settings-daemon)
in lockstep, then we break existing functionality.
It would look slightly weird, but perhaps it might be better to keep
using F22 for toggling, and F1->on, F23->off?
Thanks,
Martin
--
Martin Pitt | http://www.piware.de
Ubuntu Developer (www.ubuntu.com) | Debian Developer (www.debian.org)
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2010-11-06 15:30 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-05 0:00 Touchpad toggle mess Bastien Nocera
2010-11-05 0:00 ` Bastien Nocera
2010-11-05 2:20 ` Dmitry Torokhov
2010-11-05 2:20 ` Dmitry Torokhov
2010-11-06 15:56 ` Bastien Nocera
2010-11-06 15:56 ` Bastien Nocera
2010-11-06 15:30 ` Martin Pitt [this message]
2010-11-06 15:30 ` Martin Pitt
2010-11-06 15:58 ` Bastien Nocera
2010-11-06 15:58 ` Bastien Nocera
2010-11-06 16:33 ` Martin Pitt
2010-11-06 16:33 ` Martin Pitt
2010-11-06 17:17 ` Bastien Nocera
2010-11-06 17:17 ` Bastien Nocera
2010-11-13 18:10 ` Julien Cristau
2010-11-13 18:10 ` Julien Cristau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101106153031.GA2215@piware.de \
--to=martin.pitt@ubuntu.com \
--cc=hadess@hadess.net \
--cc=linux-hotplug@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=mjg59@srcf.ucam.org \
--cc=peter.hutterer@who-t.net \
--cc=xorg@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.