[lm-sensors] [PATCH] hwmon: (ltc4261) Fix error message format

[lm-sensors] [PATCH] hwmon: (ltc4261) Fix error message format

[Jean Delvare]

adapter->id is deprecated and not set by any adapter driver, so this
was certainly not what the author wanted to use. adapter->nr maybe,
but as dev_err() already includes this value, as well as the client's
address, there's no point repeating them. Better print a simple error
message in plain English words.

Signed-off-by: Jean Delvare <khali@linux-fr.org>
Cc: Guenter Roeck <guenter.roeck@ericsson.com>
---
 drivers/hwmon/ltc4261.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

--- linux-2.6.37-rc1.orig/drivers/hwmon/ltc4261.c	2010-11-02 09:19:35.000000000 +0100
+++ linux-2.6.37-rc1/drivers/hwmon/ltc4261.c	2010-11-05 15:56:49.000000000 +0100
@@ -230,8 +230,7 @@ static int ltc4261_probe(struct i2c_clie
 		return -ENODEV;
 
 	if (i2c_smbus_read_byte_data(client, LTC4261_STATUS) < 0) {
-		dev_err(&client->dev, "Failed to read register %d:%02x:%02x\n",
-			adapter->id, client->addr, LTC4261_STATUS);
+		dev_err(&client->dev, "Failed to read status register\n");
 		return -ENODEV;
 	}
 


-- 
Jean Delvare

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

Re: [lm-sensors] [PATCH] hwmon: (ltc4261) Fix error message format

[Guenter Roeck]

On Fri, 2010-11-05 at 10:59 -0400, Jean Delvare wrote:
> adapter->id is deprecated and not set by any adapter driver, so this
> was certainly not what the author wanted to use. adapter->nr maybe,
> but as dev_err() already includes this value, as well as the client's
> address, there's no point repeating them. Better print a simple error
> message in plain English words.
> 
> Signed-off-by: Jean Delvare <khali@linux-fr.org>
> Cc: Guenter Roeck <guenter.roeck@ericsson.com>

Acked-by: Guenter Roeck <guenter.roeck@ericsson.com>

No idea where I got that from.



_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

Re: [lm-sensors] [PATCH] hwmon: (ltc4261) Fix error message format

[Jean Delvare]

On Fri, 5 Nov 2010 09:31:20 -0700, Guenter Roeck wrote:
> On Fri, 2010-11-05 at 10:59 -0400, Jean Delvare wrote:
> > adapter->id is deprecated and not set by any adapter driver, so this
> > was certainly not what the author wanted to use. adapter->nr maybe,
> > but as dev_err() already includes this value, as well as the client's
> > address, there's no point repeating them. Better print a simple error
> > message in plain English words.
> > 
> > Signed-off-by: Jean Delvare <khali@linux-fr.org>
> > Cc: Guenter Roeck <guenter.roeck@ericsson.com>
> 
> Acked-by: Guenter Roeck <guenter.roeck@ericsson.com>
> 
> No idea where I got that from.

Do you want to take this patch in your tree, or shall I?

In both cases, I would like to get this patch in 2.6.37, as I am about
to formally deprecate i2c-adapter.id, so the current code will trigger
a build-time warning.

-- 
Jean Delvare

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

Re: [lm-sensors] [PATCH] hwmon: (ltc4261) Fix error message format

[Guenter Roeck]

On Fri, 2010-11-05 at 12:39 -0400, Jean Delvare wrote:
> On Fri, 5 Nov 2010 09:31:20 -0700, Guenter Roeck wrote:
> > On Fri, 2010-11-05 at 10:59 -0400, Jean Delvare wrote:
> > > adapter->id is deprecated and not set by any adapter driver, so this
> > > was certainly not what the author wanted to use. adapter->nr maybe,
> > > but as dev_err() already includes this value, as well as the client's
> > > address, there's no point repeating them. Better print a simple error
> > > message in plain English words.
> > > 
> > > Signed-off-by: Jean Delvare <khali@linux-fr.org>
> > > Cc: Guenter Roeck <guenter.roeck@ericsson.com>
> > 
> > Acked-by: Guenter Roeck <guenter.roeck@ericsson.com>
> > 
> > No idea where I got that from.
> 
> Do you want to take this patch in your tree, or shall I?
> 
Let me take it into my tree. I have another one-line patch for the same
driver in there already anyway, so we can avoid conflicts.

Guenter



_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

Re: [lm-sensors] [PATCH] hwmon: (ltc4261) Fix error message format

[Guenter Roeck]

On Fri, 2010-11-05 at 10:59 -0400, Jean Delvare wrote:
> adapter->id is deprecated and not set by any adapter driver, so this
> was certainly not what the author wanted to use. adapter->nr maybe,
> but as dev_err() already includes this value, as well as the client's
> address, there's no point repeating them. Better print a simple error
> message in plain English words.
> 
> Signed-off-by: Jean Delvare <khali@linux-fr.org>
> Cc: Guenter Roeck <guenter.roeck@ericsson.com>

Applied.

Thanks,
Guenter



_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

Re: [lm-sensors] [PATCH] hwmon: (ltc4261) Fix error message format

[Jean Delvare]

On Fri, 5 Nov 2010 09:48:42 -0700, Guenter Roeck wrote:
> On Fri, 2010-11-05 at 10:59 -0400, Jean Delvare wrote:
> > adapter->id is deprecated and not set by any adapter driver, so this
> > was certainly not what the author wanted to use. adapter->nr maybe,
> > but as dev_err() already includes this value, as well as the client's
> > address, there's no point repeating them. Better print a simple error
> > message in plain English words.
> > 
> > Signed-off-by: Jean Delvare <khali@linux-fr.org>
> > Cc: Guenter Roeck <guenter.roeck@ericsson.com>
> 
> Applied.

Thanks. Can you please update the LTC4261 entry in wiki/Devices too?

-- 
Jean Delvare

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

Re: [lm-sensors] [PATCH] hwmon: (ltc4261) Fix error message format

[Guenter Roeck]

On Sat, Nov 06, 2010 at 04:22:24PM -0400, Jean Delvare wrote:
> On Fri, 5 Nov 2010 09:48:42 -0700, Guenter Roeck wrote:
> > On Fri, 2010-11-05 at 10:59 -0400, Jean Delvare wrote:
> > > adapter->id is deprecated and not set by any adapter driver, so this
> > > was certainly not what the author wanted to use. adapter->nr maybe,
> > > but as dev_err() already includes this value, as well as the client's
> > > address, there's no point repeating them. Better print a simple error
> > > message in plain English words.
> > > 
> > > Signed-off-by: Jean Delvare <khali@linux-fr.org>
> > > Cc: Guenter Roeck <guenter.roeck@ericsson.com>
> > 
> > Applied.
> 
> Thanks. Can you please update the LTC4261 entry in wiki/Devices too?
> 
Done.

Guenter

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors