* MIPS: alchemy: add return value check for strict_strtoul()
@ 2010-11-08 8:23 Yoichi Yuasa
2010-11-08 22:01 ` Ralf Baechle
0 siblings, 1 reply; 2+ messages in thread
From: Yoichi Yuasa @ 2010-11-08 8:23 UTC (permalink / raw)
To: Ralf Baechle; +Cc: yuasa, linux-mips
arch/mips/alchemy/devboards/prom.c: In function 'prom_init':
arch/mips/alchemy/devboards/prom.c:60: error: ignoring return value of
'strict_strtoul', declared with attribute warn_unused_result
Signed-off-by: Yoichi Yuasa <yuasa@linux-mips.org>
---
arch/mips/alchemy/devboards/prom.c | 5 ++---
1 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/arch/mips/alchemy/devboards/prom.c b/arch/mips/alchemy/devboards/prom.c
index b30df5c..baeb213 100644
--- a/arch/mips/alchemy/devboards/prom.c
+++ b/arch/mips/alchemy/devboards/prom.c
@@ -54,10 +54,9 @@ void __init prom_init(void)
prom_init_cmdline();
memsize_str = prom_getenv("memsize");
- if (!memsize_str)
+ if (!memsize_str || strict_strtoul(memsize_str, 0, &memsize))
memsize = ALCHEMY_BOARD_DEFAULT_MEMSIZE;
- else
- strict_strtoul(memsize_str, 0, &memsize);
+
add_memory_region(0, memsize, BOOT_MEM_RAM);
}
--
1.7.3.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: MIPS: alchemy: add return value check for strict_strtoul()
2010-11-08 8:23 MIPS: alchemy: add return value check for strict_strtoul() Yoichi Yuasa
@ 2010-11-08 22:01 ` Ralf Baechle
0 siblings, 0 replies; 2+ messages in thread
From: Ralf Baechle @ 2010-11-08 22:01 UTC (permalink / raw)
To: Yoichi Yuasa; +Cc: linux-mips
Thanks, applied.
Ralf
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-11-09 4:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-11-08 8:23 MIPS: alchemy: add return value check for strict_strtoul() Yoichi Yuasa
2010-11-08 22:01 ` Ralf Baechle
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.