[PATCH] removed ad-hoc cmdline default

[PATCH] removed ad-hoc cmdline default

[Robert Millan]

[-- Attachment #1: Type: text/plain, Size: 501 bytes --]


Loongson builds have an ad-hoc cmdline default of "console=ttyS0,115200 
root=/dev/hda1". These settings come from vendor (I remember builds 
from Lemote branch requiring a "console=tty" override in order to get a 
working console).

At least on my Yeeloong, they're particularly useless: there's no 
(external) serial port, and the IDE drive is now recognised as /dev/
sda.

I recommend removing them. They make sense from a distributor/vendor 
POV but otherwise are just a nuissance.


[-- Attachment #2: loongson_cmdline.diff --]
[-- Type: text/x-patch, Size: 612 bytes --]


Remove ad-hoc cmdline settings.

Signed-off-by: Robert Millan <rmh@gnu.org>

diff --git a/arch/mips/loongson/common/cmdline.c b/arch/mips/loongson/common/cmdline.c
index 1a06def..353e1d2 100644
--- a/arch/mips/loongson/common/cmdline.c
+++ b/arch/mips/loongson/common/cmdline.c
@@ -44,10 +44,5 @@ void __init prom_init_cmdline(void)
 		strcat(arcs_cmdline, " ");
 	}
 
-	if ((strstr(arcs_cmdline, "console=")) == NULL)
-		strcat(arcs_cmdline, " console=ttyS0,115200");
-	if ((strstr(arcs_cmdline, "root=")) == NULL)
-		strcat(arcs_cmdline, " root=/dev/hda1");
-
 	prom_init_machtype();
 }

Re: [PATCH] removed ad-hoc cmdline default

[Ralf Baechle]

On Sun, Nov 07, 2010 at 01:38:29PM +0100, Robert Millan wrote:

> Loongson builds have an ad-hoc cmdline default of "console=ttyS0,115200 
> root=/dev/hda1". These settings come from vendor (I remember builds 
> from Lemote branch requiring a "console=tty" override in order to get a 
> working console).
> 
> At least on my Yeeloong, they're particularly useless: there's no 
> (external) serial port, and the IDE drive is now recognised as /dev/
> sda.
> 
> I recommend removing them. They make sense from a distributor/vendor 
> POV but otherwise are just a nuissance.

Makes sense to me but I'm not an authoritative expert for all Loongson
platforms so I'm going to wait for comments for a few days before I'm
going to apply this.

Generally forcing options like this is just a bad idea.

  Ralf

Re: [PATCH] removed ad-hoc cmdline default

[Ralf Baechle]

Applied - finally!

  Ralf