[PATCH] MIPS: Rework GENERIC_HARDIRQS Kconfig.

[PATCH] MIPS: Rework GENERIC_HARDIRQS Kconfig.

[David Daney]

Recent changes to CONFIG_GENERIC_HARDIRQS have caused us to start
getting:

warning: (SMP && SYS_SUPPORTS_SMP) selects IRQ_PER_CPU which has unmet direct dependencies (HAVE_GENERIC_HARDIRQS)

Rearranging our Kconfig quiets the message.

Signed-off-by: David Daney <ddaney@caviumnetworks.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
---
 arch/mips/Kconfig |   16 ++--------------
 1 files changed, 2 insertions(+), 14 deletions(-)

diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig
index 67a2fa2..7fc6bd1 100644
--- a/arch/mips/Kconfig
+++ b/arch/mips/Kconfig
@@ -19,6 +19,8 @@ config MIPS
 	select GENERIC_ATOMIC64 if !64BIT
 	select HAVE_DMA_ATTRS
 	select HAVE_DMA_API_DEBUG
+	select HAVE_GENERIC_HARDIRQS
+	select GENERIC_IRQ_PROBE
 
 menu "Machine selection"
 
@@ -1922,20 +1924,6 @@ config CPU_R4400_WORKAROUNDS
 	bool
 
 #
-# Use the generic interrupt handling code in kernel/irq/:
-#
-config GENERIC_HARDIRQS
-	bool
-	default y
-
-config GENERIC_IRQ_PROBE
-	bool
-	default y
-
-config IRQ_PER_CPU
-	bool
-
-#
 # - Highmem only makes sense for the 32-bit kernel.
 # - The current highmem code will only work properly on physically indexed
 #   caches such as R3000, SB1, R7000 or those that look like they're virtually
-- 
1.7.2.3

Re: [PATCH] MIPS: Rework GENERIC_HARDIRQS Kconfig.

[Ralf Baechle]

On Fri, Nov 05, 2010 at 03:12:48PM -0700, David Daney wrote:

> Recent changes to CONFIG_GENERIC_HARDIRQS have caused us to start
> getting:
> 
> warning: (SMP && SYS_SUPPORTS_SMP) selects IRQ_PER_CPU which has unmet direct dependencies (HAVE_GENERIC_HARDIRQS)
> 
> Rearranging our Kconfig quiets the message.

Thanks, applied.

I noticed that some of the same sort of cruft also still exists in
other architectures.

  Ralf