Re: [PATCH] xfstests: check block truncation after write failure

From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Marius Tolzmann <tolzmann@molgen.mpg.de>, xfs@oss.sgi.com
Subject: Re: [PATCH] xfstests: check block truncation after write failure
Date: Wed, 10 Nov 2010 09:34:26 +1100	[thread overview]
Message-ID: <20101109223426.GO2715@dastard> (raw)
In-Reply-To: <20101109114923.GA29629@infradead.org>

On Tue, Nov 09, 2010 at 06:49:23AM -0500, Christoph Hellwig wrote:
> Extraced from  https://bugzilla.kernel.org/show_bug.cgi?id=22452
> "data corruption after mmap()ing a file and writev() some data to another file"
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>

Looks good. One comment below....

Reviewed-by: Dave Chinner <david@fromorbit.com>

> +{
> +	rm -rf $file
> +	rm -rf $file.NEW
> +}
> +
> +trap "_cleanup ; exit \$status" 0 1 2 3 15
> +
> +echo -n "cccccccccc" > $file
> +$here/src/t_mmap_writev $file $file.NEW
> +xxd $file.NEW

xxd - on debian that's packaged in the vim-common package, which
not everyone will have installed (e.g. emacs users ;).

Better to use 'od -Ax' as od is part of coreutils and already used
in other qa tests so we don't introduce a new external dependency...

CHeers,

Dave.
-- 
Dave Chinner
david@fromorbit.com

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs