From: Wu Fengguang <fengguang.wu@intel.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Jan Kara <jack@suse.cz>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
Johannes Weiner <hannes@cmpxchg.org>,
Christoph Hellwig <hch@lst.de>,
Jan Engelhardt <jengelh@medozas.de>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 3/5] writeback: stop background/kupdate works from livelocking other works
Date: Wed, 10 Nov 2010 11:55:16 +0800 [thread overview]
Message-ID: <20101110035516.GA12710@localhost> (raw)
In-Reply-To: <20101110024223.847210776@intel.com>
Jan, the below comment is also updated, please double check.
>
> /*
> + * Background writeout and kupdate-style writeback may
> + * run forever. Stop them if there is other work to do
> + * so that e.g. sync can proceed. They'll be restarted
> + * after the other works are all done.
> + */
> + if ((work->for_background || work->for_kupdate) &&
> + !list_empty(&wb->bdi->work_list))
> + break;
> +
> + /*
> * For background writeout, stop when we are below the
> * background dirty threshold
> */
>
WARNING: multiple messages have this Message-ID (diff)
From: Wu Fengguang <fengguang.wu@intel.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Jan Kara <jack@suse.cz>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
Johannes Weiner <hannes@cmpxchg.org>,
Christoph Hellwig <hch@lst.de>,
Jan Engelhardt <jengelh@medozas.de>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 3/5] writeback: stop background/kupdate works from livelocking other works
Date: Wed, 10 Nov 2010 11:55:16 +0800 [thread overview]
Message-ID: <20101110035516.GA12710@localhost> (raw)
In-Reply-To: <20101110024223.847210776@intel.com>
Jan, the below comment is also updated, please double check.
>
> /*
> + * Background writeout and kupdate-style writeback may
> + * run forever. Stop them if there is other work to do
> + * so that e.g. sync can proceed. They'll be restarted
> + * after the other works are all done.
> + */
> + if ((work->for_background || work->for_kupdate) &&
> + !list_empty(&wb->bdi->work_list))
> + break;
> +
> + /*
> * For background writeout, stop when we are below the
> * background dirty threshold
> */
>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom policy in Canada: sign http://dissolvethecrtc.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2010-11-10 3:55 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-10 2:35 [PATCH 0/5] writeback livelock fixes v2 Wu Fengguang
2010-11-10 2:35 ` Wu Fengguang
2010-11-10 2:35 ` [PATCH 1/5] writeback: integrated background writeback work Wu Fengguang
2010-11-10 2:35 ` Wu Fengguang
2010-11-10 2:35 ` Wu Fengguang
2010-11-10 2:35 ` [PATCH 2/5] writeback: trace wakeup event for background writeback Wu Fengguang
2010-11-10 2:35 ` Wu Fengguang
2010-11-10 2:35 ` Wu Fengguang
2010-11-10 2:35 ` [PATCH 3/5] writeback: stop background/kupdate works from livelocking other works Wu Fengguang
2010-11-10 2:35 ` Wu Fengguang
2010-11-10 2:35 ` Wu Fengguang
2010-11-10 3:55 ` Wu Fengguang [this message]
2010-11-10 3:55 ` Wu Fengguang
2010-11-10 16:26 ` Jan Kara
2010-11-10 16:26 ` Jan Kara
2010-11-10 2:35 ` [PATCH 4/5] writeback: avoid livelocking WB_SYNC_ALL writeback Wu Fengguang
2010-11-10 2:35 ` Wu Fengguang
2010-11-10 2:35 ` Wu Fengguang
2010-11-10 2:35 ` [PATCH 5/5] writeback: check skipped pages on WB_SYNC_ALL Wu Fengguang
2010-11-10 2:35 ` Wu Fengguang
2010-11-10 2:35 ` Wu Fengguang
-- strict thread matches above, loose matches on Subject: below --
2010-11-08 23:09 [PATCH 0/5] writeback livelock fixes Wu Fengguang
2010-11-08 23:09 ` [PATCH 3/5] writeback: stop background/kupdate works from livelocking other works Wu Fengguang
2010-11-08 23:09 ` Wu Fengguang
2010-11-08 23:09 ` Wu Fengguang
2010-11-09 21:13 ` Andrew Morton
2010-11-09 21:13 ` Andrew Morton
2010-11-09 22:28 ` Jan Kara
2010-11-09 22:28 ` Jan Kara
2010-11-09 23:00 ` Andrew Morton
2010-11-09 23:00 ` Andrew Morton
2010-11-09 23:56 ` Jan Kara
2010-11-09 23:56 ` Jan Kara
2010-11-10 23:37 ` Andrew Morton
2010-11-10 23:37 ` Andrew Morton
2010-11-11 0:40 ` Wu Fengguang
2010-11-11 0:40 ` Wu Fengguang
2010-11-11 13:32 ` Christoph Hellwig
2010-11-11 13:32 ` Christoph Hellwig
2010-11-11 16:44 ` Jan Kara
2010-11-11 16:44 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101110035516.GA12710@localhost \
--to=fengguang.wu@intel.com \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=hch@lst.de \
--cc=jack@suse.cz \
--cc=jengelh@medozas.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.