From: Jonathan Nieder <jrnieder@gmail.com>
To: "Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>
Cc: git@vger.kernel.org, jnareb@gmail.com, dirson@bertin.fr,
kevin@sb.org, gitster@pobox.com, peff@peff.net
Subject: Re: [PATCH] get_sha1: support relative path "<obj>:<sth>" syntax
Date: Wed, 10 Nov 2010 11:47:36 -0600 [thread overview]
Message-ID: <20101110174736.GD11513@burratino> (raw)
In-Reply-To: <1289407021-30287-1-git-send-email-pclouds@gmail.com>
Nguyễn Thái Ngọc Duy wrote:
> This does not work in commands that startup_info is NULL
> (i.e. non-builtin ones).
That is easily fixable, no?
The non-builtins are:
fast-import
imap-send
shell
daemon
show-index
upload-pack
http-backend
http-fetch
http-push
Of those, only fast-import might have a possible reason need to know
about this new syntax.
Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
---
Assuming your patch builds on acf4823a (setup: save prefix (original
cwd relative to toplevel) in startup_info, 2010-10-24).
Untested.
diff --git a/fast-import.c b/fast-import.c
index 77549eb..3b597e8 100644
--- a/fast-import.c
+++ b/fast-import.c
@@ -2923,8 +2923,11 @@ static void parse_argv(void)
int main(int argc, const char **argv)
{
+ static struct startup_info git_startup_info;
unsigned int i;
+ startup_info = &git_startup_info;
+
git_extract_argv0_path(argv[0]);
if (argc == 2 && !strcmp(argv[1], "-h"))
next prev parent reply other threads:[~2010-11-10 17:48 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-09 7:30 [RFC] Using gitrevisions :/search style with other operators Yann Dirson
2010-11-09 8:06 ` Kevin Ballard
2010-11-09 9:24 ` Yann Dirson
2010-11-10 0:18 ` Junio C Hamano
2010-11-10 0:33 ` Kevin Ballard
2010-11-10 7:32 ` Yann Dirson
2010-11-10 7:46 ` Kevin Ballard
2010-11-10 7:46 ` Yann Dirson
2010-11-10 15:26 ` Jakub Narebski
2010-11-10 16:37 ` [PATCH] get_sha1: support relative path "<obj>:<sth>" syntax Nguyễn Thái Ngọc Duy
2010-11-10 17:17 ` Matthieu Moy
2010-11-10 17:47 ` Jonathan Nieder [this message]
2010-11-11 13:18 ` Nguyen Thai Ngoc Duy
2010-11-10 19:34 ` Junio C Hamano
2010-11-11 1:30 ` Nguyen Thai Ngoc Duy
2010-12-09 21:10 ` Junio C Hamano
2010-12-09 21:37 ` Junio C Hamano
2010-12-10 1:35 ` Nguyen Thai Ngoc Duy
2010-11-10 17:23 ` [RFC] Using gitrevisions :/search style with other operators Junio C Hamano
2010-11-10 18:19 ` Jakub Narebski
2010-11-09 16:10 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101110174736.GD11513@burratino \
--to=jrnieder@gmail.com \
--cc=dirson@bertin.fr \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jnareb@gmail.com \
--cc=kevin@sb.org \
--cc=pclouds@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.