From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Lars-Peter Clausen <lars@metafoo.de>
Cc: Trilok Soni <tsoni@codeaurora.org>,
linux-kernel@vger.kernel.org, linux-input@vger.kernel.org,
rtc-linux@googlegroups.com, linux-arm-msm@vger.kernel.org,
Richard Purdie <rpurdie@rpsys.net>
Subject: Re: [RFC v1 PATCH 3/6] led: pmic8058: Add PMIC8058 leds driver
Date: Wed, 10 Nov 2010 15:28:41 -0800 [thread overview]
Message-ID: <20101110232840.GA2121@core.coreip.homeip.net> (raw)
In-Reply-To: <4CDB0451.3090303@metafoo.de>
On Wed, Nov 10, 2010 at 09:45:05PM +0100, Lars-Peter Clausen wrote:
> Trilok Soni wrote:
> > +
> > +static void led_kp_set(struct pmic8058_led_data *led, enum led_brightness value)
> > +{
> > + int rc;
> > + u8 level;
> > + unsigned long flags;
> > +
> > + spin_lock_irqsave(&led->value_lock, flags);
> This function is only ever called from within the workqueue so there is no need for
> locking.
>
That is a common misconception, unfortunately. The same work may
be executing on several CPUs at the same time if it was scheduled on
multi-threaded work queue.
...
> > + schedule_work(&led->work);
And sure enough, keventd is such workqueue.
Now, whether having the same work run simultaneously is OK or not is a
different question altogether...
--
Dmitry
next prev parent reply other threads:[~2010-11-10 23:28 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-10 12:47 [RFC v1 PATCH 0/6] Qualcomm PMIC8058 sub-device drivers Trilok Soni
2010-11-10 12:47 ` [RFC v1 PATCH 1/6] matrix_keypad: Increase the max limit of rows and columns Trilok Soni
2010-11-10 18:33 ` Eric Miao
2010-11-10 18:33 ` Eric Miao
2010-11-10 23:30 ` Dmitry Torokhov
2010-11-10 23:30 ` Dmitry Torokhov
2010-11-17 17:54 ` Dmitry Torokhov
2010-11-10 12:47 ` [RFC v1 PATCH 2/6] input: pm8058_keypad: Qualcomm PMIC8058 keypad controller driver Trilok Soni
2010-11-16 3:49 ` Trilok Soni
2010-11-17 18:02 ` Dmitry Torokhov
2010-12-06 18:14 ` Dmitry Torokhov
2010-12-07 9:22 ` Trilok Soni
2010-12-07 9:30 ` Dmitry Torokhov
2010-12-07 9:32 ` Trilok Soni
2011-01-06 11:56 ` [rtc-linux] " Anirudh Ghayal
2010-11-10 12:47 ` [RFC v1 PATCH 3/6] led: pmic8058: Add PMIC8058 leds driver Trilok Soni
2010-11-10 20:45 ` Lars-Peter Clausen
2010-11-10 23:28 ` Dmitry Torokhov [this message]
2010-11-10 23:50 ` Lars-Peter Clausen
2010-11-11 12:15 ` Trilok Soni
2010-12-06 13:44 ` Trilok Soni
2010-12-07 15:11 ` Lars-Peter Clausen
2010-12-07 15:47 ` Trilok Soni
2010-11-10 12:47 ` [RFC v1 PATCH 4/6] input: pmic8058_pwrkey: Add support for power key Trilok Soni
2010-11-11 7:21 ` Dmitry Torokhov
2010-11-11 12:00 ` Trilok Soni
2010-11-12 0:57 ` Dmitry Torokhov
2010-11-12 8:56 ` Trilok Soni
2010-11-12 19:58 ` Dmitry Torokhov
2010-11-10 12:48 ` [RFC v1 PATCH 5/6] input: pmic8058-othc: Add support for PM8058 based OTHC Trilok Soni
2010-11-16 3:08 ` Trilok Soni
2010-11-16 5:36 ` Datta, Shubhrajyoti
2010-11-16 6:36 ` Trilok Soni
2010-12-01 5:34 ` Anirudh Ghayal
2010-12-07 10:04 ` Dmitry Torokhov
2010-12-07 12:10 ` Anirudh Ghayal
2010-11-10 12:48 ` [RFC v1 PATCH 6/6] drivers: rtc: Add support for Qualcomm PMIC8058 RTC Trilok Soni
2010-11-12 8:53 ` Trilok Soni
2010-11-12 12:53 ` Lars-Peter Clausen
2010-11-12 15:17 ` [rtc-linux] " Anirudh Ghayal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101110232840.GA2121@core.coreip.homeip.net \
--to=dmitry.torokhov@gmail.com \
--cc=lars@metafoo.de \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rpurdie@rpsys.net \
--cc=rtc-linux@googlegroups.com \
--cc=tsoni@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.