From: Thomas Rast <trast@student.ethz.ch>
To: Yann Dirson <ydirson@altern.org>
Cc: <git@vger.kernel.org>
Subject: Re: [PATCH 1/2] [RFC] Use --find- instead of --detect- as prefix for long forms of -M and -C.
Date: Thu, 11 Nov 2010 11:47:04 +0100 [thread overview]
Message-ID: <201011111147.04365.trast@student.ethz.ch> (raw)
In-Reply-To: <1289420833-20602-2-git-send-email-ydirson@altern.org>
Yann Dirson wrote:
> Rationale: this is both shorter to spell and consistent with
> --find-copies-harder.
[...]
> -M[<n>]::
> ---detect-renames[=<n>]::
> +--find-renames[=<n>]::
Umm. The reasoning seems ok for me, but the farthest you can go is
deprecating the options. Removing them as in
> - else if (!prefixcmp(arg, "-M") || !prefixcmp(arg, "--detect-renames=") ||
> - !strcmp(arg, "--detect-renames")) {
> + else if (!prefixcmp(arg, "-M") || !prefixcmp(arg, "--find-renames=") ||
> + !strcmp(arg, "--find-renames")) {
would break backwards compatibility.
--
Thomas Rast
trast@{inf,student}.ethz.ch
next prev parent reply other threads:[~2010-11-11 10:47 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-10 20:27 [PATCH] rationalize diffcore-rename options and their doc Yann Dirson
2010-11-10 20:27 ` [PATCH 1/2] [RFC] Use --find- instead of --detect- as prefix for long forms of -M and -C Yann Dirson
2010-11-11 10:47 ` Thomas Rast [this message]
2010-11-11 11:44 ` Yann Dirson
2010-11-11 22:24 ` Thomas Rast
2010-11-12 7:21 ` Yann Dirson
2010-11-12 3:00 ` Kevin Ballard
2010-11-12 3:56 ` Miles Bader
2010-11-12 7:43 ` Yann Dirson
2010-11-29 22:42 ` Junio C Hamano
2010-11-29 22:52 ` Kevin Ballard
2010-11-30 0:37 ` Junio C Hamano
2010-11-30 7:28 ` [PATCH 1/2] [RFC] Use --find- instead of --detect- as prefix for Yann Dirson
2010-11-29 21:53 ` [PATCH 1/2] [RFC] Use --find- instead of --detect- as prefix for long forms of -M and -C Yann Dirson
2010-11-29 22:44 ` Junio C Hamano
2010-11-10 20:27 ` [PATCH 2/2] Keep together options controlling the behaviour of diffcore-rename Yann Dirson
2010-11-16 17:31 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201011111147.04365.trast@student.ethz.ch \
--to=trast@student.ethz.ch \
--cc=git@vger.kernel.org \
--cc=ydirson@altern.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.