All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yann Dirson <dirson@bertin.fr>
To: git list <git@vger.kernel.org>
Cc: gister@pobox.com, kevin@sb.org
Subject: Re: [PATCH 1/2] [RFC] Use --find- instead of --detect- as prefix for
Date: Tue, 30 Nov 2010 08:28:08 +0100	[thread overview]
Message-ID: <20101130082808.415dc3c1@chalon.bertin.fr> (raw)
In-Reply-To: <7vfwujy7co.fsf@alter.siamese.dyndns.org>

Junio:
> Kevin wrote:
> > Given my druthers, I'd prefer to go with --detect-copies-harder, but
> > at this point I don't have as much of a strong preference anymore.
>
> The patch is smaller, and we often say "rename detection", not "rename
> finding", so it may probably make more sense.

OTOH:

* when cumulated to the still-recent patch adding the long forms, not
  using a synonym is shorter

* if it is just "adding a synonym" without deprecation, it only
  adds a new option for little gain; OTOH deprecating such an old
  option may not be such a good idea (not to mention it would make the
  patch longer ;)

* The --find-* forms are still shorter to spell

-- 
Yann Dirson - Bertin Technologies

  reply	other threads:[~2010-11-30  7:38 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-10 20:27 [PATCH] rationalize diffcore-rename options and their doc Yann Dirson
2010-11-10 20:27 ` [PATCH 1/2] [RFC] Use --find- instead of --detect- as prefix for long forms of -M and -C Yann Dirson
2010-11-11 10:47   ` Thomas Rast
2010-11-11 11:44     ` Yann Dirson
2010-11-11 22:24       ` Thomas Rast
2010-11-12  7:21         ` Yann Dirson
2010-11-12  3:00   ` Kevin Ballard
2010-11-12  3:56     ` Miles Bader
2010-11-12  7:43     ` Yann Dirson
2010-11-29 22:42     ` Junio C Hamano
2010-11-29 22:52       ` Kevin Ballard
2010-11-30  0:37         ` Junio C Hamano
2010-11-30  7:28           ` Yann Dirson [this message]
2010-11-29 21:53   ` Yann Dirson
2010-11-29 22:44     ` Junio C Hamano
2010-11-10 20:27 ` [PATCH 2/2] Keep together options controlling the behaviour of diffcore-rename Yann Dirson
2010-11-16 17:31   ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101130082808.415dc3c1@chalon.bertin.fr \
    --to=dirson@bertin.fr \
    --cc=gister@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=kevin@sb.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.