From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Jesse Marroquin <jesse.marroquin@maxim-ic.com>
Cc: Dimitris Papastamos <dp@opensource.wolfsonmicro.com>,
alsa-devel@alsa-project.org, Takashi Iwai <tiwai@suse.de>,
linux-kernel@vger.kernel.org,
Peter Hsiang <Peter.Hsiang@maxim-ic.com>,
Liam Girdwood <lrg@slimlogic.co.uk>
Subject: Re: [PATCH] ASoC: Add MAX98089 CODEC driver
Date: Thu, 11 Nov 2010 21:18:02 +0000 [thread overview]
Message-ID: <20101111211801.GA3399@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <4CDC5033.50302@maxim-ic.com>
On Thu, Nov 11, 2010 at 02:21:07PM -0600, Jesse Marroquin wrote:
> This patch adds the initial driver for the MAX98089 CODEC.
I've not read this properly yet but on a first quick scan through this
bears a more than passing resemblance to the MAX98088 driver - are there
sufficient incompatibilities between the chips to warrant having a
separate driver? http://datasheets.maxim-ic.com/en/ds/MAX98088.pdf
would suggest not...
Keeping a single driver means less code to maintain, which is generally
a win. Variations between the parts can be accommodated by registering
different controls and so on based on the I2C device ID that the system
registers.
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Jesse Marroquin <jesse.marroquin@maxim-ic.com>
Cc: Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.de>,
Liam Girdwood <lrg@slimlogic.co.uk>,
Peter Hsiang <Peter.Hsiang@maxim-ic.com>,
Dimitris Papastamos <dp@opensource.wolfsonmicro.com>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ASoC: Add MAX98089 CODEC driver
Date: Thu, 11 Nov 2010 21:18:02 +0000 [thread overview]
Message-ID: <20101111211801.GA3399@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <4CDC5033.50302@maxim-ic.com>
On Thu, Nov 11, 2010 at 02:21:07PM -0600, Jesse Marroquin wrote:
> This patch adds the initial driver for the MAX98089 CODEC.
I've not read this properly yet but on a first quick scan through this
bears a more than passing resemblance to the MAX98088 driver - are there
sufficient incompatibilities between the chips to warrant having a
separate driver? http://datasheets.maxim-ic.com/en/ds/MAX98088.pdf
would suggest not...
Keeping a single driver means less code to maintain, which is generally
a win. Variations between the parts can be accommodated by registering
different controls and so on based on the I2C device ID that the system
registers.
next prev parent reply other threads:[~2010-11-11 21:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-11 20:21 [PATCH] ASoC: Add MAX98089 CODEC driver Jesse Marroquin
2010-11-11 20:21 ` Jesse Marroquin
2010-11-11 21:18 ` Mark Brown [this message]
2010-11-11 21:18 ` Mark Brown
2010-11-11 23:16 ` Jesse Marroquin
2010-11-11 23:16 ` Jesse Marroquin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101111211801.GA3399@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=Peter.Hsiang@maxim-ic.com \
--cc=alsa-devel@alsa-project.org \
--cc=dp@opensource.wolfsonmicro.com \
--cc=jesse.marroquin@maxim-ic.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@slimlogic.co.uk \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.