All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: linux-arm-kernel@lists.infradead.org
Cc: linux-omap@vger.kernel.org, Felipe Balbi <balbi@ti.com>
Subject: [PATCH 4/4] arm: omap1: devices: need to return with a value
Date: Thu, 11 Nov 2010 17:03:34 -0800	[thread overview]
Message-ID: <20101112010334.3827.77064.stgit@baageli.muru.com> (raw)
In-Reply-To: <20101112010245.3827.75329.stgit@baageli.muru.com>

From: Felipe Balbi <balbi@ti.com>

Get rid of the following warning:

arch/arm/mach-omap1/devices.c: In function 'omap_init_wdt':
arch/arm/mach-omap1/devices.c:298: warning: 'return' with
no value, in function returning non-void

while at that, also change:

platform_device_register();
return 0;

into:

return platform_device_register();

Signed-off-by: Felipe Balbi <balbi@ti.com>
Signed-off-by: Tony Lindgren <tony@atomide.com>
---
 arch/arm/mach-omap1/devices.c |    5 ++---
 1 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/arch/arm/mach-omap1/devices.c b/arch/arm/mach-omap1/devices.c
index ea0d80a..e7f9ee6 100644
--- a/arch/arm/mach-omap1/devices.c
+++ b/arch/arm/mach-omap1/devices.c
@@ -321,10 +321,9 @@ static struct platform_device omap_wdt_device = {
 static int __init omap_init_wdt(void)
 {
 	if (!cpu_is_omap16xx())
-		return;
+		return -ENODEV;
 
-	platform_device_register(&omap_wdt_device);
-	return 0;
+	return platform_device_register(&omap_wdt_device);
 }
 subsys_initcall(omap_init_wdt);
 #endif


WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/4] arm: omap1: devices: need to return with a value
Date: Thu, 11 Nov 2010 17:03:34 -0800	[thread overview]
Message-ID: <20101112010334.3827.77064.stgit@baageli.muru.com> (raw)
In-Reply-To: <20101112010245.3827.75329.stgit@baageli.muru.com>

From: Felipe Balbi <balbi@ti.com>

Get rid of the following warning:

arch/arm/mach-omap1/devices.c: In function 'omap_init_wdt':
arch/arm/mach-omap1/devices.c:298: warning: 'return' with
no value, in function returning non-void

while at that, also change:

platform_device_register();
return 0;

into:

return platform_device_register();

Signed-off-by: Felipe Balbi <balbi@ti.com>
Signed-off-by: Tony Lindgren <tony@atomide.com>
---
 arch/arm/mach-omap1/devices.c |    5 ++---
 1 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/arch/arm/mach-omap1/devices.c b/arch/arm/mach-omap1/devices.c
index ea0d80a..e7f9ee6 100644
--- a/arch/arm/mach-omap1/devices.c
+++ b/arch/arm/mach-omap1/devices.c
@@ -321,10 +321,9 @@ static struct platform_device omap_wdt_device = {
 static int __init omap_init_wdt(void)
 {
 	if (!cpu_is_omap16xx())
-		return;
+		return -ENODEV;
 
-	platform_device_register(&omap_wdt_device);
-	return 0;
+	return platform_device_register(&omap_wdt_device);
 }
 subsys_initcall(omap_init_wdt);
 #endif

  parent reply	other threads:[~2010-11-12  1:03 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-12  1:03 [PATCH 0/4] omap fixes for v2.6.37-rc1 Tony Lindgren
2010-11-12  1:03 ` Tony Lindgren
2010-11-12  1:03 ` [PATCH 1/4] OMAP2: Devkit8000: Fix mmc regulator failure Tony Lindgren
2010-11-12  1:03   ` Tony Lindgren
2010-11-12  1:03 ` [PATCH 2/4] omap: dma: Add read-back to DMA interrupt handler to avoid spuriousinterrupts Tony Lindgren
2010-11-12  1:03   ` Tony Lindgren
2010-11-12 17:48   ` Tony Lindgren
2010-11-12  1:03 ` [PATCH 3/4] OMAP1: camera.h: add missing include Tony Lindgren
2010-11-12  1:03   ` Tony Lindgren
2010-11-12  1:03 ` Tony Lindgren [this message]
2010-11-12  1:03   ` [PATCH 4/4] arm: omap1: devices: need to return with a value Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101112010334.3827.77064.stgit@baageli.muru.com \
    --to=tony@atomide.com \
    --cc=balbi@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-omap@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.