From: Dan Carpenter <error27@gmail.com>
To: Vasiliy Kulikov <segoon@openwall.com>
Cc: David Woodhouse <dwmw2@infradead.org>,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mtd@lists.infradead.org
Subject: Re: [PATCH] fs: jffs2: fix error value sign
Date: Sun, 14 Nov 2010 20:29:05 +0000 [thread overview]
Message-ID: <20101114202905.GA21614@bicker> (raw)
In-Reply-To: <1289765320-6071-1-git-send-email-segoon@openwall.com>
On Sun, Nov 14, 2010 at 11:08:39PM +0300, Vasiliy Kulikov wrote:
> do_verify_xattr_datum(), do_load_xattr_datum(), load_xattr_datum()
> and verify_xattr_ref() should return negative value on error.
> Sometimes they return EIO that is positive. Change this to -EIO.
>
> Signed-off-by: Vasiliy Kulikov <segoon@openwall.com>
> ---
> This driver is not compilable, so the patch is not tested.
>
It compiles.
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <error27@gmail.com>
To: Vasiliy Kulikov <segoon@openwall.com>
Cc: David Woodhouse <dwmw2@infradead.org>,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mtd@lists.infradead.org
Subject: Re: [PATCH] fs: jffs2: fix error value sign
Date: Sun, 14 Nov 2010 23:29:05 +0300 [thread overview]
Message-ID: <20101114202905.GA21614@bicker> (raw)
In-Reply-To: <1289765320-6071-1-git-send-email-segoon@openwall.com>
On Sun, Nov 14, 2010 at 11:08:39PM +0300, Vasiliy Kulikov wrote:
> do_verify_xattr_datum(), do_load_xattr_datum(), load_xattr_datum()
> and verify_xattr_ref() should return negative value on error.
> Sometimes they return EIO that is positive. Change this to -EIO.
>
> Signed-off-by: Vasiliy Kulikov <segoon@openwall.com>
> ---
> This driver is not compilable, so the patch is not tested.
>
It compiles.
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <error27@gmail.com>
To: Vasiliy Kulikov <segoon@openwall.com>
Cc: kernel-janitors@vger.kernel.org,
David Woodhouse <dwmw2@infradead.org>,
linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fs: jffs2: fix error value sign
Date: Sun, 14 Nov 2010 23:29:05 +0300 [thread overview]
Message-ID: <20101114202905.GA21614@bicker> (raw)
In-Reply-To: <1289765320-6071-1-git-send-email-segoon@openwall.com>
On Sun, Nov 14, 2010 at 11:08:39PM +0300, Vasiliy Kulikov wrote:
> do_verify_xattr_datum(), do_load_xattr_datum(), load_xattr_datum()
> and verify_xattr_ref() should return negative value on error.
> Sometimes they return EIO that is positive. Change this to -EIO.
>
> Signed-off-by: Vasiliy Kulikov <segoon@openwall.com>
> ---
> This driver is not compilable, so the patch is not tested.
>
It compiles.
regards,
dan carpenter
next prev parent reply other threads:[~2010-11-14 20:29 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-14 20:08 [PATCH] fs: jffs2: fix error value sign Vasiliy Kulikov
2010-11-14 20:08 ` Vasiliy Kulikov
2010-11-14 20:08 ` Vasiliy Kulikov
2010-11-14 20:29 ` Dan Carpenter [this message]
2010-11-14 20:29 ` Dan Carpenter
2010-11-14 20:29 ` Dan Carpenter
2010-11-15 14:37 ` Vasiliy Kulikov
2010-11-15 14:37 ` Vasiliy Kulikov
2010-11-15 18:45 ` Dan Carpenter
2010-11-15 18:45 ` Dan Carpenter
2010-11-15 18:45 ` Dan Carpenter
2010-11-15 19:18 ` Vasiliy Kulikov
2010-11-15 19:18 ` Vasiliy Kulikov
2010-11-26 16:05 ` Artem Bityutskiy
2010-11-26 16:05 ` Artem Bityutskiy
2010-11-26 16:05 ` Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101114202905.GA21614@bicker \
--to=error27@gmail.com \
--cc=dwmw2@infradead.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=segoon@openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.