From: Wei Wang2 <wei.wang2@amd.com>
To: Jan Beulich <JBeulich@novell.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
Keir Fraser <keir.fraser@eu.citrix.com>
Subject: [PATCH] amd iommu: Fix HV crash with 32bit pv_ops kernel (V2)
Date: Mon, 15 Nov 2010 14:58:23 +0100 [thread overview]
Message-ID: <201011151458.24610.wei.wang2@amd.com> (raw)
In-Reply-To: <4CE1379702000078000223D4@vpn.id2.novell.com>
[-- Attachment #1: Type: text/plain, Size: 893 bytes --]
Hi Jan
Could this new version be a little more clear?
Thanks,
Wei
Signed-off-by: Wei Wang <wei.wang2@amd.com>
On Monday 15 November 2010 13:37:27 Jan Beulich wrote:
> >>> On 15.11.10 at 11:18, Wei Wang2 <wei.wang2@amd.com> wrote:
> >
> >--- a/xen/include/asm-x86/hvm/svm/amd-iommu-proto.h Wed Nov 10 14:56:06
> > 2010 +0000 +++ b/xen/include/asm-x86/hvm/svm/amd-iommu-proto.h Fri Nov 12
> > 17:10:31 2010 +0100 @@ -31,8 +31,8 @@
> >
> > #define DMA_32BIT_MASK 0x00000000ffffffffULL
> >
> >-extern int amd_iommu_debug;
> >-extern int amd_iommu_perdev_intremap;
> >+extern bool_t amd_iommu_debug;
> >+extern bool_t amd_iommu_perdev_intremap;
> >
> > #define AMD_IOMMU_DEBUG(fmt, args...) \
> > do \
>
> This surely can't be complete: If you had a type mismatch between
> declaration and definition, the defining code is clearly missing an
> #include of the #define-ing header.
>
> Jan
[-- Attachment #2: fix_pv_ops_32_v2.patch --]
[-- Type: text/x-diff, Size: 963 bytes --]
diff -r 388c44a63613 xen/include/asm-x86/hvm/svm/amd-iommu-proto.h
--- a/xen/include/asm-x86/hvm/svm/amd-iommu-proto.h Wed Nov 10 14:56:06 2010 +0000
+++ b/xen/include/asm-x86/hvm/svm/amd-iommu-proto.h Mon Nov 15 14:49:52 2010 +0100
@@ -30,9 +30,6 @@
&amd_iommu_head, list)
#define DMA_32BIT_MASK 0x00000000ffffffffULL
-
-extern int amd_iommu_debug;
-extern int amd_iommu_perdev_intremap;
#define AMD_IOMMU_DEBUG(fmt, args...) \
do \
diff -r 388c44a63613 xen/include/xen/iommu.h
--- a/xen/include/xen/iommu.h Wed Nov 10 14:56:06 2010 +0000
+++ b/xen/include/xen/iommu.h Mon Nov 15 14:49:52 2010 +0100
@@ -30,6 +30,8 @@ extern bool_t force_iommu, iommu_verbose
extern bool_t force_iommu, iommu_verbose;
extern bool_t iommu_workaround_bios_bug, iommu_passthrough;
extern bool_t iommu_snoop, iommu_qinval, iommu_intremap;
+extern bool_t amd_iommu_debug;
+extern bool_t amd_iommu_perdev_intremap;
extern struct rangeset *mmio_ro_ranges;
[-- Attachment #3: Type: text/plain, Size: 138 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel
next prev parent reply other threads:[~2010-11-15 13:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-15 10:18 [PATCH] amd iommu: Fix HV crach with 32bit pv_ops kernel Wei Wang2
2010-11-15 12:37 ` Jan Beulich
2010-11-15 13:58 ` Wei Wang2 [this message]
2010-11-15 15:36 ` [PATCH] amd iommu: Fix HV crash with 32bit pv_ops kernel(V2) Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201011151458.24610.wei.wang2@amd.com \
--to=wei.wang2@amd.com \
--cc=JBeulich@novell.com \
--cc=keir.fraser@eu.citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.