All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: "Måns Rullgård" <mans@mansr.com>
Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] omap4: enable L2 prefetching
Date: Tue, 16 Nov 2010 10:11:57 -0800	[thread overview]
Message-ID: <20101116181157.GY9264@atomide.com> (raw)
In-Reply-To: <yw1xaala8qex.fsf@unicorn.mansr.com>

* Måns Rullgård <mans@mansr.com> [101115 09:01]:
> Nishanth Menon <nm@ti.com> writes:
> 
> > From: Mans Rullgard <mans@mansr.com>
> >
> > Enabling L2 prefetching improves performance as shown on Panda
> > ES2.1 board with mem test, and it has measurable impact on
> > performances. I think we should consider it, even though it damages
> > "writes" a bit. (rebased to k.org)
> > Usually the prefetch is used at both levels together L1 + L2, however,
> > to enable the CP15 prefetch engines, these are under security, and on
> > GP devices, we cannot enable it(e.g. on PandaBoard). However, just
> > enabling PL310 prefetch seems to provide performance improvement,
> > as shown in the data below (from Ubuntu) and would be a great thing
> > to pull in.
> 
> What this does is enable automatic next line prefetching.  With this
> enabled, whenever the PL310 receives a cachable read request, it
> automatically prefetches the following cache line as well.  A larger
> offset can be programmed in secure mode, but the TI ROM authors
> neglected to include this.
> 
> Testing with FFmpeg showed a speedup of 10% with this patch in some
> cases.

Måns and Nishant, care to repost this with the updated comments?

Regards,

Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] omap4: enable L2 prefetching
Date: Tue, 16 Nov 2010 10:11:57 -0800	[thread overview]
Message-ID: <20101116181157.GY9264@atomide.com> (raw)
In-Reply-To: <yw1xaala8qex.fsf@unicorn.mansr.com>

* M?ns Rullg?rd <mans@mansr.com> [101115 09:01]:
> Nishanth Menon <nm@ti.com> writes:
> 
> > From: Mans Rullgard <mans@mansr.com>
> >
> > Enabling L2 prefetching improves performance as shown on Panda
> > ES2.1 board with mem test, and it has measurable impact on
> > performances. I think we should consider it, even though it damages
> > "writes" a bit. (rebased to k.org)
> > Usually the prefetch is used at both levels together L1 + L2, however,
> > to enable the CP15 prefetch engines, these are under security, and on
> > GP devices, we cannot enable it(e.g. on PandaBoard). However, just
> > enabling PL310 prefetch seems to provide performance improvement,
> > as shown in the data below (from Ubuntu) and would be a great thing
> > to pull in.
> 
> What this does is enable automatic next line prefetching.  With this
> enabled, whenever the PL310 receives a cachable read request, it
> automatically prefetches the following cache line as well.  A larger
> offset can be programmed in secure mode, but the TI ROM authors
> neglected to include this.
> 
> Testing with FFmpeg showed a speedup of 10% with this patch in some
> cases.

M?ns and Nishant, care to repost this with the updated comments?

Regards,

Tony

  reply	other threads:[~2010-11-16 18:12 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-15 16:20 [PATCH] omap4: enable L2 prefetching Nishanth Menon
2010-11-15 16:20 ` Nishanth Menon
2010-11-15 17:09 ` Måns Rullgård
2010-11-16 18:11   ` Tony Lindgren [this message]
2010-11-16 18:11     ` Tony Lindgren
2010-11-16 18:49 ` Kevin Hilman
2010-11-16 18:49   ` Kevin Hilman
2010-11-19 16:46   ` Santosh Shilimkar
2010-11-19 16:46     ` Santosh Shilimkar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101116181157.GY9264@atomide.com \
    --to=tony@atomide.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=mans@mansr.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.