From: Tony Lindgren <tony@atomide.com>
To: Kevin Hilman <khilman@deeprootsystems.com>
Cc: Grant Erickson <marathon96@gmail.com>, linux-omap@vger.kernel.org
Subject: Re: [PATCH] Add OMAP Support for Generic PWM Devices using Dual-mode Timers
Date: Tue, 16 Nov 2010 12:20:31 -0800 [thread overview]
Message-ID: <20101116202031.GD9264@atomide.com> (raw)
In-Reply-To: <87hbfhcagv.fsf@deeprootsystems.com>
* Kevin Hilman <khilman@deeprootsystems.com> [101116 11:43]:
> Grant Erickson <marathon96@gmail.com> writes:
>
> [...]
>
> >> Before something like this can merge, I would rather see
> >>
> >> 1) generic PWM framework pushed along and merged
> >> 2) the dmtimer hwmod conversion finished
> >>
> >> Yes, I know it's a lot more work to fix the core/framework code before
> >> having a feature included, but having something more generic that can
> >> actually support multiple PWM sources is clearly needed.
> >
> > No disagreement on the long-term architectural and design goals. All good
> > stuff.
> >
> > However, patches have to be submitted against the repository and branch we
> > have today, not those we might have tomorrow.
>
> This comment is where we diverge.
>
> An alternative to waiting for the generic framework cleanup/refactor
> work is to contribute to it and help it along.
Yeah I agree, with Kevin. We should not export any more omap specific
functions in arch/arm/*omap*/ as they always lead into maintenance
nightmares later on. We still have several merge cycles of work just
to get rid of the existing exported functions.
Regards,
Tony
next prev parent reply other threads:[~2010-11-16 20:20 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-14 19:28 [PATCH] Add OMAP Support for Generic PWM Devices using Dual-mode Timers Grant Erickson
2010-11-16 12:37 ` Hemanth V
2010-11-16 17:45 ` Grant Erickson
2010-11-17 9:58 ` Hemanth V
2010-11-16 12:42 ` Felipe Balbi
2010-11-16 18:00 ` Grant Erickson
2010-11-16 17:01 ` Kevin Hilman
2010-11-16 18:13 ` Grant Erickson
2010-11-16 18:43 ` Kevin Hilman
2010-11-16 19:39 ` Grant Erickson
2010-11-16 19:52 ` Kevin Hilman
2010-11-16 20:20 ` Tony Lindgren [this message]
2010-11-16 18:54 ` Premi, Sanjeev
2010-11-16 19:11 ` Grant Erickson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101116202031.GD9264@atomide.com \
--to=tony@atomide.com \
--cc=khilman@deeprootsystems.com \
--cc=linux-omap@vger.kernel.org \
--cc=marathon96@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.