Re: [PATCH] Add OMAP Support for Generic PWM Devices using Dual-mode Timers

[Grant Erickson <marathon96@gmail.com>]

On 11/16/10 4:37 AM, Hemanth V wrote:
> ----- Original Message -----
> From: "Grant Erickson" <marathon96@gmail.com>
> Sent: Monday, November 15, 2010 12:58 AM
> 
>> This patch adds support to request and use one or more of the OMAP
>> dual-mode timers as a generic PWM device compatible with other generic
>> PWM drivers such as the PWM backlight or PWM beeper driver.
> 
> Generally PWMs are supported on PMIC chip.  Is this driver intended for use
> when OMAP is used standalone?

Correct. 

>> Boards can register such devices using platform data such as in the
>> following
>> example:
>> 
>> static struct omap2_pwm_platform_config pwm_config = {
>>     .timer_id           = 10,   // GPT10_PWM_EVT
> 
> Since only specific GPTs can be configured for PWM, can some check
> we added in probe function?

Yes, that check is already present in the probe function:

    pwm->dm_timer = omap_dm_timer_request_specific(pdata->timer_id);

    if (pwm->dm_timer == NULL) {
        status = -ENOENT;
        goto err_free;
    }

> Can the above file  be part of mach-omap2, since comment say its
> specifically for OMAP2/3 or will this work on OMAP1 also?

It should work wherever dmtimers are supported. To the extent that dmtimer.c
is in plat-omap/, I located pwm.c there as well.

Thanks for the feedback!

Best,

Grant