* [patch 1/3] [media] lirc_dev: stray unlock in lirc_dev_fop_poll()
@ 2010-11-17 5:12 ` Dan Carpenter
0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2010-11-17 5:12 UTC (permalink / raw)
To: Mauro Carvalho Chehab
Cc: Jarod Wilson, Zimny Lech, linux-media, kernel-janitors
We shouldn't unlock here. I think this was a cut and paste error.
Signed-off-by: Dan Carpenter <error27@gmail.com>
diff --git a/drivers/media/IR/lirc_dev.c b/drivers/media/IR/lirc_dev.c
index 8418b14..8ab9d87 100644
--- a/drivers/media/IR/lirc_dev.c
+++ b/drivers/media/IR/lirc_dev.c
@@ -522,10 +522,8 @@ unsigned int lirc_dev_fop_poll(struct file *file, poll_table *wait)
dev_dbg(ir->d.dev, LOGHEAD "poll called\n", ir->d.name, ir->d.minor);
- if (!ir->attached) {
- mutex_unlock(&ir->irctl_lock);
+ if (!ir->attached)
return POLLERR;
- }
poll_wait(file, &ir->buf->wait_poll, wait);
^ permalink raw reply related [flat|nested] 4+ messages in thread* [patch 1/3] [media] lirc_dev: stray unlock in lirc_dev_fop_poll()
@ 2010-11-17 5:12 ` Dan Carpenter
0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2010-11-17 5:12 UTC (permalink / raw)
To: Mauro Carvalho Chehab
Cc: Jarod Wilson, Zimny Lech, linux-media, kernel-janitors
We shouldn't unlock here. I think this was a cut and paste error.
Signed-off-by: Dan Carpenter <error27@gmail.com>
diff --git a/drivers/media/IR/lirc_dev.c b/drivers/media/IR/lirc_dev.c
index 8418b14..8ab9d87 100644
--- a/drivers/media/IR/lirc_dev.c
+++ b/drivers/media/IR/lirc_dev.c
@@ -522,10 +522,8 @@ unsigned int lirc_dev_fop_poll(struct file *file, poll_table *wait)
dev_dbg(ir->d.dev, LOGHEAD "poll called\n", ir->d.name, ir->d.minor);
- if (!ir->attached) {
- mutex_unlock(&ir->irctl_lock);
+ if (!ir->attached)
return POLLERR;
- }
poll_wait(file, &ir->buf->wait_poll, wait);
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [patch 1/3] [media] lirc_dev: stray unlock in lirc_dev_fop_poll()
2010-11-17 5:12 ` Dan Carpenter
@ 2010-11-17 20:21 ` Jarod Wilson
-1 siblings, 0 replies; 4+ messages in thread
From: Jarod Wilson @ 2010-11-17 20:21 UTC (permalink / raw)
To: Dan Carpenter
Cc: Mauro Carvalho Chehab, Zimny Lech, linux-media, kernel-janitors
On Wed, Nov 17, 2010 at 08:12:23AM +0300, Dan Carpenter wrote:
> We shouldn't unlock here. I think this was a cut and paste error.
Yeah, looks like it.
Acked-by: Jarod Wilson <jarod@redhat.com>
--
Jarod Wilson
jarod@redhat.com
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2010-11-17 20:21 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-11-17 5:12 [patch 1/3] [media] lirc_dev: stray unlock in lirc_dev_fop_poll() Dan Carpenter
2010-11-17 5:12 ` Dan Carpenter
2010-11-17 20:21 ` Jarod Wilson
2010-11-17 20:21 ` Jarod Wilson
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.