From: Andrew Morton <akpm@linux-foundation.org>
To: Michal Hocko <mhocko@suse.cz>
Cc: Daisuke Nishimura <nishimura@mxp.nes.nec.co.jp>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
balbir@linux.vnet.ibm.com,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Subject: Re: [PATCH] Make swap accounting default behavior configurable v4
Date: Thu, 18 Nov 2010 09:52:47 -0800 [thread overview]
Message-ID: <20101118095247.2445b092.akpm@linux-foundation.org> (raw)
In-Reply-To: <20101118102349.GF15928@tiehlicka.suse.cz>
On Thu, 18 Nov 2010 11:23:49 +0100 Michal Hocko <mhocko@suse.cz> wrote:
> > I'm sorry again and again, but I think removing "noswapaccount" completely
> > would be better, as Andrew said first:
>
> I read the above Andrew's statement that we really should stick with the
> old parameter.
yup. We shouldn't remove the existing parameter, which people might be
using already.
> > > So we have swapaccount and noswapaccount. Ho hum, "swapaccount=[1|0]"
> > > would have been better.
What I meant was that it was a mistake to add the "noswapaccount" in
the first place. We should have made it "swapaccount=0", because that
would leave open the later option of reversing the default, and
enabling "swapaccount=1".
It also give us the option of adding "swapaccount=2"! Perhaps to
enable alternative swap accounting behaviour.
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Morton <akpm@linux-foundation.org>
To: Michal Hocko <mhocko@suse.cz>
Cc: Daisuke Nishimura <nishimura@mxp.nes.nec.co.jp>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
balbir@linux.vnet.ibm.com,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Subject: Re: [PATCH] Make swap accounting default behavior configurable v4
Date: Thu, 18 Nov 2010 09:52:47 -0800 [thread overview]
Message-ID: <20101118095247.2445b092.akpm@linux-foundation.org> (raw)
In-Reply-To: <20101118102349.GF15928@tiehlicka.suse.cz>
On Thu, 18 Nov 2010 11:23:49 +0100 Michal Hocko <mhocko@suse.cz> wrote:
> > I'm sorry again and again, but I think removing "noswapaccount" completely
> > would be better, as Andrew said first:
>
> I read the above Andrew's statement that we really should stick with the
> old parameter.
yup. We shouldn't remove the existing parameter, which people might be
using already.
> > > So we have swapaccount and noswapaccount. Ho hum, "swapaccount=[1|0]"
> > > would have been better.
What I meant was that it was a mistake to add the "noswapaccount" in
the first place. We should have made it "swapaccount=0", because that
would leave open the later option of reversing the default, and
enabling "swapaccount=1".
It also give us the option of adding "swapaccount=2"! Perhaps to
enable alternative swap accounting behaviour.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom policy in Canada: sign http://dissolvethecrtc.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2010-11-18 17:57 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-16 10:17 [PATCH] Make swap accounting default behavior configurable Michal Hocko
2010-11-16 10:17 ` Michal Hocko
2010-11-16 20:46 ` Andrew Morton
2010-11-16 20:46 ` Andrew Morton
2010-11-16 21:21 ` [stable] " Greg KH
2010-11-16 21:21 ` Greg KH
2010-11-18 8:21 ` Michal Hocko
2010-11-18 8:21 ` Michal Hocko
2010-11-18 16:36 ` Greg KH
2010-11-18 16:36 ` Greg KH
2010-11-17 0:23 ` Daisuke Nishimura
2010-11-17 0:23 ` Daisuke Nishimura
2010-11-17 0:57 ` KAMEZAWA Hiroyuki
2010-11-17 0:57 ` KAMEZAWA Hiroyuki
2010-11-17 1:12 ` Andrew Morton
2010-11-17 1:12 ` Andrew Morton
2010-11-17 3:28 ` Daisuke Nishimura
2010-11-17 3:28 ` Daisuke Nishimura
2010-11-18 8:23 ` Michal Hocko
2010-11-18 8:23 ` Michal Hocko
2010-11-18 8:46 ` Daisuke Nishimura
2010-11-18 8:46 ` Daisuke Nishimura
2010-11-18 8:53 ` KAMEZAWA Hiroyuki
2010-11-18 8:53 ` KAMEZAWA Hiroyuki
2010-11-18 9:56 ` [PATCH] Make swap accounting default behavior configurable v4 Michal Hocko
2010-11-18 9:56 ` Michal Hocko
2010-11-18 10:14 ` Daisuke Nishimura
2010-11-18 10:14 ` Daisuke Nishimura
2010-11-18 10:23 ` Michal Hocko
2010-11-18 10:23 ` Michal Hocko
2010-11-18 17:52 ` Andrew Morton [this message]
2010-11-18 17:52 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101118095247.2445b092.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=balbir@linux.vnet.ibm.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.cz \
--cc=nishimura@mxp.nes.nec.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.