All of lore.kernel.org
 help / color / mirror / Atom feed
From: Oleg Nesterov <oleg@redhat.com>
To: Dhaval Giani <dhaval.giani@gmail.com>
Cc: a.p.zijlstra@chello.nl, mingo@elte.hu, akinobu.mita@gmail.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] cpu.c: remove unused variable
Date: Thu, 18 Nov 2010 16:37:26 +0100	[thread overview]
Message-ID: <20101118153726.GA587@redhat.com> (raw)
In-Reply-To: <1290091494.1145.5.camel@gondor.retis>

On 11/18, Dhaval Giani wrote:
>
> --- linux-2.6.orig/kernel/cpu.c
> +++ linux-2.6/kernel/cpu.c
> @@ -197,7 +197,6 @@ struct take_cpu_down_param {
>  static int __ref take_cpu_down(void *_param)
>  {
>  	struct take_cpu_down_param *param = _param;
> -	unsigned int cpu = (unsigned long)param->hcpu;
>  	int err;

This is on top of Peter's patch, I guess.

Agreed, it looks unused.

Oleg.


  reply	other threads:[~2010-11-18 15:44 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-18 14:44 [PATCH] cpu.c: remove unused variable Dhaval Giani
2010-11-18 15:37 ` Oleg Nesterov [this message]
2010-11-18 15:49   ` Dhaval Giani
  -- strict thread matches above, loose matches on Subject: below --
2010-11-18 14:41 Dhaval Giani

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101118153726.GA587@redhat.com \
    --to=oleg@redhat.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=akinobu.mita@gmail.com \
    --cc=dhaval.giani@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.