* [PATCH] cpu.c: remove unused variable
@ 2010-11-18 14:44 Dhaval Giani
2010-11-18 15:37 ` Oleg Nesterov
0 siblings, 1 reply; 4+ messages in thread
From: Dhaval Giani @ 2010-11-18 14:44 UTC (permalink / raw)
To: a.p.zijlstra, mingo, oleg, akinobu.mita; +Cc: linux-kernel
cpu.c: remove unused variable
kernel/cpu.c: In function ‘take_cpu_down’:
kernel/cpu.c:200:15: warning: unused variable ‘cpu’
This variable is unused since param->hcpu is directly
used later on in cpu_notify.
Signed-off-by: Dhaval Giani <dhaval_giani@gmail.com>
---
kernel/cpu.c | 1 -
1 file changed, 1 deletion(-)
Index: linux-2.6/kernel/cpu.c
===================================================================
--- linux-2.6.orig/kernel/cpu.c
+++ linux-2.6/kernel/cpu.c
@@ -197,7 +197,6 @@ struct take_cpu_down_param {
static int __ref take_cpu_down(void *_param)
{
struct take_cpu_down_param *param = _param;
- unsigned int cpu = (unsigned long)param->hcpu;
int err;
/* Ensure this CPU doesn't handle any more interrupts. */
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] cpu.c: remove unused variable
2010-11-18 14:44 [PATCH] cpu.c: remove unused variable Dhaval Giani
@ 2010-11-18 15:37 ` Oleg Nesterov
2010-11-18 15:49 ` Dhaval Giani
0 siblings, 1 reply; 4+ messages in thread
From: Oleg Nesterov @ 2010-11-18 15:37 UTC (permalink / raw)
To: Dhaval Giani; +Cc: a.p.zijlstra, mingo, akinobu.mita, linux-kernel
On 11/18, Dhaval Giani wrote:
>
> --- linux-2.6.orig/kernel/cpu.c
> +++ linux-2.6/kernel/cpu.c
> @@ -197,7 +197,6 @@ struct take_cpu_down_param {
> static int __ref take_cpu_down(void *_param)
> {
> struct take_cpu_down_param *param = _param;
> - unsigned int cpu = (unsigned long)param->hcpu;
> int err;
This is on top of Peter's patch, I guess.
Agreed, it looks unused.
Oleg.
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] cpu.c: remove unused variable
2010-11-18 15:37 ` Oleg Nesterov
@ 2010-11-18 15:49 ` Dhaval Giani
0 siblings, 0 replies; 4+ messages in thread
From: Dhaval Giani @ 2010-11-18 15:49 UTC (permalink / raw)
To: Oleg Nesterov; +Cc: a.p.zijlstra, mingo, akinobu.mita, linux-kernel
On Thu, Nov 18, 2010 at 4:37 PM, Oleg Nesterov <oleg@redhat.com> wrote:
> On 11/18, Dhaval Giani wrote:
>>
>> --- linux-2.6.orig/kernel/cpu.c
>> +++ linux-2.6/kernel/cpu.c
>> @@ -197,7 +197,6 @@ struct take_cpu_down_param {
>> static int __ref take_cpu_down(void *_param)
>> {
>> struct take_cpu_down_param *param = _param;
>> - unsigned int cpu = (unsigned long)param->hcpu;
>> int err;
>
> This is on top of Peter's patch, I guess.
>
current tip/master, so I guess so :-) Now if I can just figure out why
this configuration mess does not boot for me ;-)
Dhaval
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] cpu.c: remove unused variable
@ 2010-11-18 14:41 Dhaval Giani
0 siblings, 0 replies; 4+ messages in thread
From: Dhaval Giani @ 2010-11-18 14:41 UTC (permalink / raw)
To: a.p.zijlstra, mingo, linux-kernel, akinobu.mita, oleg
cpu.c: remove unused variable
kernel/cpu.c: In function ‘take_cpu_down’:
kernel/cpu.c:200:15: warning: unused variable ‘cpu’
This variable is unused since param->hcpu is directly
used later on in cpu_notify.
Signed-off-by: Dhaval Giani <dhaval_giani@gmail.com>
---
kernel/cpu.c | 1 -
1 file changed, 1 deletion(-)
Index: linux-2.6/kernel/cpu.c
===================================================================
--- linux-2.6.orig/kernel/cpu.c
+++ linux-2.6/kernel/cpu.c
@@ -197,7 +197,6 @@ struct take_cpu_down_param {
static int __ref take_cpu_down(void *_param)
{
struct take_cpu_down_param *param = _param;
- unsigned int cpu = (unsigned long)param->hcpu;
int err;
/* Ensure this CPU doesn't handle any more interrupts. */
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2010-11-18 15:50 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-11-18 14:44 [PATCH] cpu.c: remove unused variable Dhaval Giani
2010-11-18 15:37 ` Oleg Nesterov
2010-11-18 15:49 ` Dhaval Giani
-- strict thread matches above, loose matches on Subject: below --
2010-11-18 14:41 Dhaval Giani
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.