* [PATCH] omap: nand: remove hardware ECC as default
@ 2010-11-18 14:22 Sukumar Ghorai
2010-11-18 18:01 ` Tony Lindgren
0 siblings, 1 reply; 4+ messages in thread
From: Sukumar Ghorai @ 2010-11-18 14:22 UTC (permalink / raw)
To: linux-omap; +Cc: linux-mtd, Sukumar Ghorai
CONFIG_MTD_NAND_OMAP_HWECC defined wronly in patch submitted during 2.6.36
that using the hardware ECC by default
Signed-off-by: Sukumar Ghorai <s-ghorai@ti.com>
---
drivers/mtd/nand/omap2.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/mtd/nand/omap2.c b/drivers/mtd/nand/omap2.c
index cd41c58..15682ec 100644
--- a/drivers/mtd/nand/omap2.c
+++ b/drivers/mtd/nand/omap2.c
@@ -7,7 +7,6 @@
* it under the terms of the GNU General Public License version 2 as
* published by the Free Software Foundation.
*/
-#define CONFIG_MTD_NAND_OMAP_HWECC
#include <linux/platform_device.h>
#include <linux/dma-mapping.h>
--
1.7.0.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] omap: nand: remove hardware ECC as default
2010-11-18 14:22 [PATCH] omap: nand: remove hardware ECC as default Sukumar Ghorai
@ 2010-11-18 18:01 ` Tony Lindgren
2010-11-19 10:44 ` Grazvydas Ignotas
0 siblings, 1 reply; 4+ messages in thread
From: Tony Lindgren @ 2010-11-18 18:01 UTC (permalink / raw)
To: Sukumar Ghorai; +Cc: linux-omap, linux-mtd
* Sukumar Ghorai <s-ghorai@ti.com> [101118 06:12]:
> CONFIG_MTD_NAND_OMAP_HWECC defined wronly in patch submitted during 2.6.36
> that using the hardware ECC by default
>
> Signed-off-by: Sukumar Ghorai <s-ghorai@ti.com>
> ---
> drivers/mtd/nand/omap2.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/mtd/nand/omap2.c b/drivers/mtd/nand/omap2.c
> index cd41c58..15682ec 100644
> --- a/drivers/mtd/nand/omap2.c
> +++ b/drivers/mtd/nand/omap2.c
> @@ -7,7 +7,6 @@
> * it under the terms of the GNU General Public License version 2 as
> * published by the Free Software Foundation.
> */
> -#define CONFIG_MTD_NAND_OMAP_HWECC
>
> #include <linux/platform_device.h>
> #include <linux/dma-mapping.h>
This looks like a fix for the -rc cycle. Can you please update
the description a bit to specify which commit broke it and
what the error is now?
Regards,
Tony
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] omap: nand: remove hardware ECC as default
2010-11-18 18:01 ` Tony Lindgren
@ 2010-11-19 10:44 ` Grazvydas Ignotas
0 siblings, 0 replies; 4+ messages in thread
From: Grazvydas Ignotas @ 2010-11-19 10:44 UTC (permalink / raw)
To: Tony Lindgren; +Cc: Charles Manning, linux-omap, linux-mtd, Sukumar Ghorai
On Thu, Nov 18, 2010 at 8:01 PM, Tony Lindgren <tony@atomide.com> wrote:
> * Sukumar Ghorai <s-ghorai@ti.com> [101118 06:12]:
>> CONFIG_MTD_NAND_OMAP_HWECC defined wronly in patch submitted during 2.6.36
>> that using the hardware ECC by default
wrongly
>>
>> Signed-off-by: Sukumar Ghorai <s-ghorai@ti.com>
>> ---
>> drivers/mtd/nand/omap2.c | 1 -
>> 1 files changed, 0 insertions(+), 1 deletions(-)
>>
>> diff --git a/drivers/mtd/nand/omap2.c b/drivers/mtd/nand/omap2.c
>> index cd41c58..15682ec 100644
>> --- a/drivers/mtd/nand/omap2.c
>> +++ b/drivers/mtd/nand/omap2.c
>> @@ -7,7 +7,6 @@
>> * it under the terms of the GNU General Public License version 2 as
>> * published by the Free Software Foundation.
>> */
>> -#define CONFIG_MTD_NAND_OMAP_HWECC
>>
>> #include <linux/platform_device.h>
>> #include <linux/dma-mapping.h>
>
> This looks like a fix for the -rc cycle. Can you please update
> the description a bit to specify which commit broke it and
> what the error is now?
Well it broke NAND for beagle and pandora at least, as those have been
using sw ecc, all IO simply results in ECC errors with that define.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] omap: nand: remove hardware ECC as default
@ 2010-11-19 10:44 ` Grazvydas Ignotas
0 siblings, 0 replies; 4+ messages in thread
From: Grazvydas Ignotas @ 2010-11-19 10:44 UTC (permalink / raw)
To: Tony Lindgren; +Cc: Sukumar Ghorai, linux-omap, linux-mtd, Charles Manning
On Thu, Nov 18, 2010 at 8:01 PM, Tony Lindgren <tony@atomide.com> wrote:
> * Sukumar Ghorai <s-ghorai@ti.com> [101118 06:12]:
>> CONFIG_MTD_NAND_OMAP_HWECC defined wronly in patch submitted during 2.6.36
>> that using the hardware ECC by default
wrongly
>>
>> Signed-off-by: Sukumar Ghorai <s-ghorai@ti.com>
>> ---
>> drivers/mtd/nand/omap2.c | 1 -
>> 1 files changed, 0 insertions(+), 1 deletions(-)
>>
>> diff --git a/drivers/mtd/nand/omap2.c b/drivers/mtd/nand/omap2.c
>> index cd41c58..15682ec 100644
>> --- a/drivers/mtd/nand/omap2.c
>> +++ b/drivers/mtd/nand/omap2.c
>> @@ -7,7 +7,6 @@
>> * it under the terms of the GNU General Public License version 2 as
>> * published by the Free Software Foundation.
>> */
>> -#define CONFIG_MTD_NAND_OMAP_HWECC
>>
>> #include <linux/platform_device.h>
>> #include <linux/dma-mapping.h>
>
> This looks like a fix for the -rc cycle. Can you please update
> the description a bit to specify which commit broke it and
> what the error is now?
Well it broke NAND for beagle and pandora at least, as those have been
using sw ecc, all IO simply results in ECC errors with that define.
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2010-11-19 10:44 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-11-18 14:22 [PATCH] omap: nand: remove hardware ECC as default Sukumar Ghorai
2010-11-18 18:01 ` Tony Lindgren
2010-11-19 10:44 ` Grazvydas Ignotas
2010-11-19 10:44 ` Grazvydas Ignotas
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.