All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alan Cox <alan@linux.intel.com>
To: Vasiliy Kulikov <segoon@openwall.com>
Cc: kernel-janitors@vger.kernel.org,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
	x86@kernel.org, Feng Tang <feng.tang@intel.com>,
	Arjan van de Ven <arjan@linux.intel.com>,
	Jacob Pan <jacob.jun.pan@linux.intel.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] x86: platform: mrst: check
Date: Thu, 18 Nov 2010 18:18:14 +0000	[thread overview]
Message-ID: <20101118181814.290811f0@linux.intel.com> (raw)
In-Reply-To: <1290104207-31279-1-git-send-email-segoon@openwall.com>

>  I cannot compile this driver in next-20101117, so it is not tested
> at all.

Compile or test - if it bombs out compiling for you please send me (off
list the .config that fails so I can fix that

Otherwise NAK the patch because it needs to do the cleanup but thanks
for finding the bug - you've done the hard 99%

Alan

WARNING: multiple messages have this Message-ID (diff)
From: Alan Cox <alan@linux.intel.com>
To: Vasiliy Kulikov <segoon@openwall.com>
Cc: kernel-janitors@vger.kernel.org,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
	x86@kernel.org, Feng Tang <feng.tang@intel.com>,
	Arjan van de Ven <arjan@linux.intel.com>,
	Jacob Pan <jacob.jun.pan@linux.intel.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] x86: platform: mrst: check platform_device_register() return code
Date: Thu, 18 Nov 2010 18:18:14 +0000	[thread overview]
Message-ID: <20101118181814.290811f0@linux.intel.com> (raw)
In-Reply-To: <1290104207-31279-1-git-send-email-segoon@openwall.com>

>  I cannot compile this driver in next-20101117, so it is not tested
> at all.

Compile or test - if it bombs out compiling for you please send me (off
list the .config that fails so I can fix that

Otherwise NAK the patch because it needs to do the cleanup but thanks
for finding the bug - you've done the hard 99%

Alan

  reply	other threads:[~2010-11-18 18:18 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-18 18:16 [PATCH 1/4] x86: platform: mrst: check platform_device_register() return code Vasiliy Kulikov
2010-11-18 18:16 ` Vasiliy Kulikov
2010-11-18 18:18 ` Alan Cox [this message]
2010-11-18 18:18   ` Alan Cox
2010-11-18 18:44   ` [PATCH 1/4] x86: platform: mrst: check Vasiliy Kulikov
2010-11-18 18:44     ` [PATCH 1/4] x86: platform: mrst: check platform_device_register() return code Vasiliy Kulikov
2010-11-18 20:18     ` [PATCH 1/4] x86: platform: mrst: check Alan Cox
2010-11-18 20:18       ` [PATCH 1/4] x86: platform: mrst: check platform_device_register() return code Alan Cox
2010-11-18 21:27       ` [PATCH 1/4] x86: platform: mrst: check platform_device_register() Thomas Gleixner
2010-11-18 21:27         ` [PATCH 1/4] x86: platform: mrst: check platform_device_register() return code Thomas Gleixner
2010-11-18 20:19 ` [PATCH 1/4] x86: platform: mrst: check Alan Cox
2010-11-18 20:19   ` [PATCH 1/4] x86: platform: mrst: check platform_device_register() return code Alan Cox
2010-11-18 21:49 ` [tip:x86/platform] x86, mrst: Check " tip-bot for Vasiliy Kulikov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101118181814.290811f0@linux.intel.com \
    --to=alan@linux.intel.com \
    --cc=arjan@linux.intel.com \
    --cc=feng.tang@intel.com \
    --cc=hpa@zytor.com \
    --cc=jacob.jun.pan@linux.intel.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=segoon@openwall.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.